Skip to content

Updated change log #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 12, 2017
Merged

Updated change log #160

merged 2 commits into from
May 12, 2017

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented May 4, 2017

Please review master. I will tag 1.5.0 after this PR is merged.

@Nyholm Nyholm added this to the Version 1.5.0 milestone May 4, 2017
@Nyholm Nyholm requested a review from dbu May 4, 2017 13:37
@fbourigault
Copy link
Contributor

What about #142 for HttpAsyncClient?

@fbourigault
Copy link
Contributor

We have to remove https://github.com/php-http/HttplugBundle/blob/master/DependencyInjection/HttplugExtension.php#L437-L438 because it's no longer required since #135.

@fbourigault fbourigault mentioned this pull request May 10, 2017
Merged
@Nyholm
Copy link
Member Author

Nyholm commented May 10, 2017

There is already mention of #142.

Support for autowring in Symfony 3.3

@Nyholm
Copy link
Member Author

Nyholm commented May 10, 2017

I just created some PRs for 1.5.0. Just smaller things. Im fine with releasing 1.5.0 after they are accepted.

@Nyholm
Copy link
Member Author

Nyholm commented May 10, 2017

@dbu Are you fine with releasing 1.5.0?

@dbu
Copy link
Collaborator

dbu commented May 11, 2017 via email

@Nyholm
Copy link
Member Author

Nyholm commented May 11, 2017

Im confident. But there is no rush. I will release this on Monday if not before.

@fbourigault
Copy link
Contributor

I'm confident too :)

dbu
dbu approved these changes May 11, 2017
View reviewed changes
Copy link
Collaborator

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice you added some more fixes. i guess the BC break discovered in #166 needs to be fixed before we release however. apart from that i'd release now before you add further features that then again might need time to mature.

@Nyholm
Copy link
Member Author

Nyholm commented May 11, 2017

Thank you.
Yeah #166 is a blocker

@Nyholm Nyholm merged commit 23a9837 into master May 12, 2017
@Nyholm Nyholm deleted the Nyholm-patch-2 branch May 12, 2017 10:52
@dbu dbu mentioned this pull request Feb 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 1.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Nyholm @fbourigault @dbu @sagikazarmark