Skip to content

run tests against php 7.1 #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2017
Merged

run tests against php 7.1 #148

merged 1 commit into from
Apr 14, 2017

Conversation

fbourigault
Copy link
Contributor

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets N/A
Documentation N/A
License MIT

This add php 7.1 in travis-ci matrix.

@Nyholm Nyholm self-requested a review April 13, 2017 21:18
@xabbuh
Copy link
Member

xabbuh commented Apr 14, 2017

Currently, all three listed Symfony versions will be run against every configured PHP versions. Thus, the build matrix does not only get one but three additional jobs. As the Travis CI quota for the number of jobs run in parallel applies to all repositories in the php-http organisation what do you think about reducing the number of jobs here and run tests with different Symfony versions only with one PHP version?

@Nyholm
Copy link
Member

Nyholm commented Apr 14, 2017

@xabbuh you are correct. I will make a PR with the suggested changes.

@fbourigault Thank you!

@Nyholm Nyholm merged commit 98ab0a7 into php-http:master Apr 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants