Skip to content

Fixed typos #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 23, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions Collector/DebugPluginCollector.php
Original file line number Diff line number Diff line change
Expand Up @@ -78,11 +78,11 @@ public function addFailure(Exception $exception, $clientName, $depth)
}

/**
* Returns the successful request-resonse pairs.
* Returns the successful request-response pairs.
*
* @return array
* @return int
*/
public function getSucessfulRequests()
public function getSuccessfulRequests()
{
$count = 0;
foreach ($this->data as $client) {
Expand All @@ -99,9 +99,9 @@ public function getSucessfulRequests()
}

/**
* Returns the failed request-resonse pairs.
* Returns the failed request-response pairs.
*
* @return array
* @return int
*/
public function getFailedRequests()
{
Expand All @@ -126,7 +126,7 @@ public function getFailedRequests()
*/
public function getTotalRequests()
{
return $this->getSucessfulRequests() + $this->getFailedRequests();
return $this->getSuccessfulRequests() + $this->getFailedRequests();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not wear my glasses when I was making this class.. Obviously...

}

/**
Expand Down
8 changes: 4 additions & 4 deletions Collector/RequestStackProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -74,13 +74,13 @@ public static function createFromCollectedData(array $data)
*/
private static function createOne($messages)
{
$orderedFaulure = [];
$orderedFailure = [];
$orderedRequests = [];
$orderedResponses = [];

foreach ($messages['failure'] as $depth => $failures) {
foreach ($failures as $idx => $failure) {
$orderedFaulure[$idx][$depth] = $failure;
$orderedFailure[$idx][$depth] = $failure;
}
}

Expand All @@ -96,7 +96,7 @@ private static function createOne($messages)
}
}

return new self($orderedFaulure, $orderedRequests, $orderedResponses);
return new self($orderedFailure, $orderedRequests, $orderedResponses);
}

/**
Expand All @@ -114,7 +114,7 @@ public function getStackIndexKeys()
*
* @return array
*/
public function getRequstStack($idx)
public function getRequestStack($idx)
{
return $this->requests[$idx];
}
Expand Down
3 changes: 1 addition & 2 deletions DependencyInjection/HttplugExtension.php
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ private function configureClients(ContainerBuilder $container, array $config)

foreach ($config['clients'] as $name => $arguments) {
if ($first === null) {
// Save the name of the first configurated client.
// Save the name of the first configured client.
$first = $name;
}

Expand Down Expand Up @@ -304,7 +304,6 @@ function ($id) {
->addArgument($pluginClientOptions)
;


/*
* Decorate the client with clients from client-common
*/
Expand Down
2 changes: 1 addition & 1 deletion Resources/public/script/httplug.js
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ var httplug_isHidden = function (el) {
}

/**
* Toggle visibility on elemets
* Toggle visibility on elements
* @param els
* @param display defaults to "block"
*/
Expand Down
2 changes: 1 addition & 1 deletion Tests/Unit/DependencyInjection/HttplugExtensionTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ public function testProfilingWhenToolbarIsSpecificallyOn()

$this->assertTrue(isset($arguments[3]));
$this->assertTrue(isset($arguments[3]['debug_plugins']));
$this->assertFalse(empty($arguments[3]['debug_plugins']));
$this->assertNotEmpty($arguments[3]['debug_plugins']);
}

private function verifyProfilingDisabled()
Expand Down