Merge Profiling back to main extension #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sagikazarmark
force-pushed
the
dev-issue95-2
branch
2 times, most recently
from
062c37a to
614d55b
Compare
| @@ -20,6 +20,23 @@ | |||
| class Configuration implements ConfigurationInterface | |||
| { | |||
| /** | |||
| * Whether to use the debug mode. | |||
| * | |||
| * @see https://github.com/doctrine/DoctrineBundle/blob/master/DependencyInjection/Configuration.php#L31-L41 | |||
There was a problem hiding this comment.
If you want to have a reference to a line you should probably do it to a tag instead of master:
https://github.com/doctrine/DoctrineBundle/blob/v1.5.2/DependencyInjection/Configuration.php#L31-L41
|
Im 👍 I like how you fixed the kernel.debug thing. I just had some minor comments. |
sagikazarmark
force-pushed
the
dev-issue95-2
branch
from
84acd5d to
bc7aaa1
Compare
Separating profiling into a separate class does not make the code cleaner or more readable. In this commit: - Profiling moved back to main extension - Toolbar (profiling) defaults to kernel.debug
sagikazarmark
force-pushed
the
dev-issue95-2
branch
from
bc7aaa1 to
4f76044
Compare
|
Thanks for the review. Merge whenever you think it's ready. I will merge the other PR then. |
|
I would like to do a final review before merging to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Merge back ProfileExtension to the main one and fix the kernel debug fallback problem.
Why?
Separating profiling into a separate class does not make the code cleaner or more readable.