Cannot run tests on master because trait `...VersionBridgePlugin` is not found

[ruudk]

I'm trying to run vendor/bin/simple-phpunit on master, but it fails:

$ vendor/bin/simple-phpunit
symfony/yaml is not required in your composer.json and has not been removed
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies
Package operations: 23 installs, 0 updates, 0 removals
  - Installing phpunit/php-timer (1.0.9): Loading from cache
  - Installing sebastian/global-state (2.0.0): Loading from cache
  - Installing sebastian/recursion-context (3.0.0): Loading from cache
  - Installing sebastian/object-reflector (1.1.1): Loading from cache
  - Installing sebastian/object-enumerator (3.0.3): Loading from cache
  - Installing sebastian/resource-operations (1.0.0): Loading from cache
  - Installing phar-io/version (1.0.1): Loading from cache
  - Installing phar-io/manifest (1.0.1): Loading from cache
  - Installing myclabs/deep-copy (1.7.0): Loading from cache
  - Installing theseer/tokenizer (1.1.0): Loading from cache
  - Installing sebastian/version (2.0.1): Loading from cache
  - Installing sebastian/environment (3.1.0): Loading from cache
  - Installing sebastian/code-unit-reverse-lookup (1.0.1): Loading from cache
  - Installing phpunit/php-token-stream (2.0.2): Loading from cache
  - Installing phpunit/php-text-template (1.2.1): Loading from cache
  - Installing phpunit/php-file-iterator (1.4.5): Loading from cache
  - Installing phpunit/php-code-coverage (5.3.2): Loading from cache
  - Installing sebastian/exporter (3.1.0): Loading from cache
  - Installing doctrine/instantiator (1.0.5): Loading from cache
  - Installing phpunit/phpunit-mock-objects (5.0.10): Loading from cache
  - Installing sebastian/diff (2.0.1): Loading from cache
  - Installing sebastian/comparator (2.1.3): Loading from cache
  - Installing symfony/phpunit-bridge (6.5.99): Symlinking from /Volumes/CS/www/HttplugBundle/vendor/symfony/phpunit-bridge
Writing lock file
Generating optimized autoload files
PHP Fatal error:  Trait 'Http\Client\Common\Plugin\VersionBridgePlugin' not found in /Volumes/CS/www/HttplugBundle/Tests/Functional/ProfilingTest.php on line 125

Fatal error: Trait 'Http\Client\Common\Plugin\VersionBridgePlugin' not found in /Volumes/CS/www/HttplugBundle/Tests/Functional/ProfilingTest.php on line 125

[dbu]

did you run a composer update before running the test? the version bridge thing has been recently added to allow migration from httplug to the psr-18 client interface (with the return type declaration). can you make sure that you have php-http/client-common in version 1.9.0?

[ruudk]

Ah, I know the issue: composer.lock is in .gitignore so I didn't notice this file was stale. Now it works.

Wouldn't it be better to remove it from .gitignore?

[xabbuh]

If the file wasn't in the .gitignore file, people would commit it accidentally when making pull requests.