Skip to content

Clarify the scope of this PER in the meta document #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions meta.md
Original file line number Diff line number Diff line change
Expand Up @@ -44,18 +44,26 @@ This PER shares the same goals as PSR-12.
> of guidelines to be used among all those projects. Thus, the benefit of this guide is
> not in the rules themselves, but in the sharing of those rules.

This PER is an extension of PSR-12, and therefore also an extension of PSR-1.
This PER extends, expands and replaces PSR-12, and is therefore also an extension of PSR-1.
With PSR-12 being the base of this PER, a list of differences is provided below to assist with migration,
but it should be considered as an independent specification.

This PER will eventually incorporate and replace any stylistic requirements found in PSR-1.
PSR-1 includes a number of non-stylistic requirements that affect runtime behavior, which are
out of scope for this PER. If a particular rule is mentioned in both this PER and PSR-1,
this PER takes precedence. If not, the PSR-1 rule (including errata) still applies.

This PER will include coding style guidelines related to new functionality added to PHP
after the publication of PSR-12. This PER will also include clarifications on the text of
PSR-12.
after the publication of PSR-12, as well as clarifications on the text of PSR-12.
It is a goal of this PER to maintain style consistency between related old and new PHP syntax,
such as class constants and constants in enumerations. In rare cases, this may cause new
releases to include coding style guidelines that break backwards compatibility, limited by
the non-goals and versioning sections below.

### 3.2. Non-Goals

It is not the intention of this PER to add entirely new coding style guidelines. It will
also not change anything stipulated in PSR-1 and PSR-12.
It is not the intention of this PER to substantially or arbitrarily alter coding style guidelines found in PSR-1 and PSR-12.
It will not change anything stipulated in PSR-1 that concerns technical interoperability or runtime behaviour.
Comment on lines +65 to +66
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
It is not the intention of this PER to substantially or arbitrarily alter coding style guidelines found in PSR-1 and PSR-12.
It will not change anything stipulated in PSR-1 that concerns technical interoperability or runtime behaviour.
* It is not the intention of this PER to arbitrarily alter coding style guidelines found in PSR-1 and PSR-12.
* It is not the intention of this PER to change any elements of PSR-1 that concern technical interoperability or runtime behavior.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I perceive this suggestion as less firm on not changing runtime elements of PSR-1 and not making large changes (measured by number of rules touched), only a single issue we've identified as possibly in scope. I'm concerned that may make it less pallatable to anyone on the fence about this change. Wdyt?


## 4. Approaches

Expand Down