-
Notifications
You must be signed in to change notification settings - Fork 441
Fix snsqs non-SNS SQS message headers #1183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@makasim could you please review this? Thanks! |
The change looks good to, though tests fail. They have to be fixed before I can merge |
@makasim looks like the PHP packages from Sury aren't there any more for EOL versions of Ubuntu and PHP, so could you please review and merge makasim/docker-nginx-php-fpm#4, then push the 7.4 image? 🙏 Then I can update this PR to use 7.4 in functional tests. |
sure |
@andrewmy great job, thank you! |
@makasim thanks for the merge! 🎉 Could we have a release? :) |
In snsqs usage scenario you still get non-SNS messages when you resend a message for retrying.
Additional unrelated fixes to make it right: