Skip to content

Fix snsqs non-SNS SQS message headers #1183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 23, 2021

Conversation

andrewmy
Copy link
Contributor

@andrewmy andrewmy commented Jul 9, 2021

In snsqs usage scenario you still get non-SNS messages when you resend a message for retrying.

Additional unrelated fixes to make it right:

  • Fixed functional test runner in CI to apply different PHP versions rather than the same one;
  • Dropped PHP 7.3 and added 7.4 to the functional test matrix;
  • Bumped dependencies to versions compatible with PHP 8.0;
  • Bump react libs to fix wamp hanging on PHP 8.

@andrewmy
Copy link
Contributor Author

@makasim could you please review this? Thanks!

@makasim
Copy link
Member

makasim commented Jul 19, 2021

The change looks good to, though tests fail. They have to be fixed before I can merge

@andrewmy
Copy link
Contributor Author

@makasim looks like the PHP packages from Sury aren't there any more for EOL versions of Ubuntu and PHP, so could you please review and merge makasim/docker-nginx-php-fpm#4, then push the 7.4 image? 🙏

Then I can update this PR to use 7.4 in functional tests.

@makasim
Copy link
Member

makasim commented Jul 23, 2021

@makasim looks like the PHP packages from Sury aren't there any more for EOL versions of Ubuntu and PHP, so could you please review and merge makasim/docker-nginx-php-fpm#4, then push the 7.4 image? 🙏

sure

@makasim makasim merged commit 62ec057 into php-enqueue:master Jul 23, 2021
@makasim
Copy link
Member

makasim commented Jul 23, 2021

@andrewmy great job, thank you!

@andrewmy
Copy link
Contributor Author

@makasim thanks for the merge! 🎉 Could we have a release? :)

@makasim
Copy link
Member

makasim commented Jul 23, 2021

https://github.com/php-enqueue/snsqs/releases/tag/0.10.12

@andrewmy andrewmy deleted the fix-snsqs-headers branch December 24, 2021 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants