Skip to content

docs: port diagrams to PlantUML #1379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2020

Conversation

demianova
Copy link
Contributor

Fix #1363

@demianova demianova requested a review from php-coder as a code owner May 1, 2020 21:20
@mystamps-bot
Copy link

1 Message
📖 @demianova thank you for the PR! All quality checks have been passed! Next step is to wait when @php-coder will review this code

Generated by 🚫 Danger

@demianova demianova force-pushed the convert_diagrams branch from bfd4264 to f8478f5 Compare May 1, 2020 21:43
@demianova demianova force-pushed the convert_diagrams branch from f8478f5 to 27ff1b8 Compare May 1, 2020 21:55
Copy link
Owner

@php-coder php-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! 🥇

@php-coder
Copy link
Owner

Travis failed with unrelated errors:

  1. rflint fails because one of its dependency:
=====> Run robot framework lint

Traceback (most recent call last):
  File "/home/travis/.local/bin/rflint", line 5, in <module>
    from rflint.__main__ import main
  File "/home/travis/.local/lib/python2.7/site-packages/rflint/__init__.py", line 1, in <module>
    from .rflint import RfLint, ERROR, WARNING
  File "/home/travis/.local/lib/python2.7/site-packages/rflint/rflint.py", line 30, in <module>
    from .parser import RobotFactory, SuiteFile, ResourceFile
  File "/home/travis/.local/lib/python2.7/site-packages/rflint/parser/__init__.py", line 1, in <module>
    from .parser import (SuiteFolder, ResourceFile, SuiteFile, RobotFactory, 
  File "/home/travis/.local/lib/python2.7/site-packages/rflint/parser/parser.py", line 24, in <module>
    from robot.parsing.txtreader import TxtReader
ImportError: No module named txtreader
  1. Danger doesn't like push with force:
=====> Run danger

fatal: couldn't find remote ref refs/heads/convert_diagrams
fatal: couldn't find remote ref refs/heads/convert_diagrams
fatal: couldn't find remote ref refs/heads/convert_diagrams
fatal: couldn't find remote ref refs/heads/convert_diagrams
From https://github.com/php-coder/mystamps
 * [new tag]           0.1        -> 0.1
 * [new tag]           0.1.1      -> 0.1.1
 * [new tag]           0.1.2      -> 0.1.2
 * [new tag]           0.1.3      -> 0.1.3
 * [new tag]           0.2        -> 0.2
 * [new tag]           0.3        -> 0.3
 * [new tag]           0.4        -> 0.4
 * [new tag]           0.4.1      -> 0.4.1
 * [new tag]           0.4.2      -> 0.4.2
/home/travis/.rvm/gems/ruby-2.5.3/gems/danger-7.0.1/lib/danger/scm_source/git_repo.rb:117:in `raise_if_we_cannot_find_the_commit': Commit 27ff1b8d doesn't exist. Are you running `danger local/pr` against the correct repository? Also this usually happens when you rebase/reset and force-pushed. (RuntimeError)
	from /home/travis/.rvm/gems/ruby-2.5.3/gems/danger-7.0.1/lib/danger/scm_source/git_repo.rb:99:in `ensure_commitish_exists_on_branch!'
	from /home/travis/.rvm/gems/ruby-2.5.3/gems/danger-7.0.1/lib/danger/request_sources/github/github.rb:112:in `setup_danger_branches'
	from /home/travis/.rvm/gems/ruby-2.5.3/gems/danger-7.0.1/lib/danger/danger_core/environment_manager.rb:58:in `ensure_danger_branches_are_setup'
	from /home/travis/.rvm/gems/ruby-2.5.3/gems/danger-7.0.1/lib/danger/danger_core/dangerfile.rb:269:in `setup_for_running'
	from /home/travis/.rvm/gems/ruby-2.5.3/gems/danger-7.0.1/lib/danger/danger_core/dangerfile.rb:280:in `run'
	from /home/travis/.rvm/gems/ruby-2.5.3/gems/danger-7.0.1/lib/danger/danger_core/executor.rb:29:in `run'
	from /home/travis/.rvm/gems/ruby-2.5.3/gems/danger-7.0.1/lib/danger/commands/runner.rb:73:in `run'
	from /home/travis/.rvm/gems/ruby-2.5.3/gems/claide-1.0.3/lib/claide/command.rb:334:in `run'
	from /home/travis/.rvm/gems/ruby-2.5.3/gems/danger-7.0.1/bin/danger:5:in `<top (required)>'
	from /home/travis/.rvm/gems/ruby-2.5.3/bin/danger:23:in `load'
	from /home/travis/.rvm/gems/ruby-2.5.3/bin/danger:23:in `<main>'
	from /home/travis/.rvm/gems/ruby-2.5.3/bin/ruby_executable_hooks:24:in `eval'
	from /home/travis/.rvm/gems/ruby-2.5.3/bin/ruby_executable_hooks:24:in `<main>'

@php-coder php-coder merged commit 27ff1b8 into php-coder:master May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert diagrams to PlantUML
3 participants