Skip to content

Add integration tests for showing similar series #1116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2019
Merged

Add integration tests for showing similar series #1116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/resources/liquibase/version/0.4.1.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@

<include file="0.4.1/2019-07-21--series_sales_transaction_url_length.xml" relativeToChangelogFile="true"/>
<include file="0.4.1/2019-08-06--test_user_with_series_in_collection.xml" relativeToChangelogFile="true"/>

<include file="0.4.1/2019-08-31--test_similar_series.xml" relativeToChangelogFile="true"/>

</databaseChangeLog>
37 changes: 37 additions & 0 deletions src/main/resources/liquibase/version/0.4.1/2019-08-31--test_similar_series.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
<?xml version="1.0" encoding="UTF-8"?>
<databaseChangeLog
xmlns="http://www.liquibase.org/xml/ns/dbchangelog"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog
http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-3.0.xsd">

<changeSet id="create-similar-series" author="mukeshk" context="test-data">
<comment>Creates two series and mark them as similar</comment>

<insert tableName="series">
<column name="quantity" valueNumeric="4" />
<column name="perforated" valueBoolean="TRUE" />
<column name="category_id" valueNumeric="1" />
<column name="created_at" valueComputed="${NOW}" />
<column name="created_by" valueComputed="(SELECT id FROM users ORDER BY id LIMIT 1)" />
<column name="updated_at" valueComputed="${NOW}" />
<column name="updated_by" valueComputed="(SELECT id FROM users ORDER BY id LIMIT 1)" />
</insert>

<insert tableName="series">
<column name="quantity" valueNumeric="5" />
<column name="perforated" valueBoolean="TRUE" />
<column name="category_id" valueNumeric="1" />
<column name="created_at" valueComputed="${NOW}" />
<column name="created_by" valueComputed="(SELECT id FROM users ORDER BY id LIMIT 1)" />
<column name="updated_at" valueComputed="${NOW}" />
<column name="updated_by" valueComputed="(SELECT id FROM users ORDER BY id LIMIT 1)" />
</insert>

<insert tableName="similar_series">
<column name="series_id" valueComputed="(SELECT id FROM series WHERE quantity = 4 ORDER BY id LIMIT 1)" />
<column name="similar_series_id" valueComputed="(SELECT id FROM series WHERE quantity = 5 ORDER BY id LIMIT 1)" />
</insert>
</changeSet>

</databaseChangeLog>
3 changes: 1 addition & 2 deletions src/main/webapp/WEB-INF/views/series/info.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,8 +338,7 @@
</dl>
</div>
</div>
<div class="row" th:if="${not #lists.isEmpty(similarSeries)}">
<!--/* @todo #967 Add integration tests for showing similar series */-->
<div id="similar-series" class="row" th:if="${not #lists.isEmpty(similarSeries)}">
<div class="col-sm-10 col-sm-offset-2">
<h5 class="text-center" th:text="#{t_similar_series}">
Similar series
Expand Down
18 changes: 18 additions & 0 deletions src/test/robotframework/series/similar/logic.robot
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
*** Settings ***
Documentation Verify logic for similar series
Library SeleniumLibrary
Suite Setup Before Test Suite
Suite Teardown Close Browser
Force Tags series similar-series logic

*** Test Cases ***
Similar series should be linked to each other
Go To ${SITE_URL}/series/4
Page Should Contain Element css=#similar-series [href="/series/5"]
Go To ${SITE_URL}/series/5
Page Should Contain Element css=#similar-series [href="/series/4"]

*** Keywords ***
Before Test Suite
Open Browser ${SITE_URL}/ ${BROWSER}
Register Keyword To Run On Failure Log Source