Skip to content

Automate code review process with Danger (maximum requirements) #537

Closed as not planned
@php-coder

Description

@php-coder
  • warn when author's name doesn't contains surname (for example, MrRobot <root@example.org>)
  • warn about branches in my repository (xxx wants to merge 1 commit into master from gh510deny_add_and_list_as_country_names)
  • html5validator: why build not fails?
  • html5validator: handle multilines (1.16-5.73) (see https://travis-ci.org/php-coder/mystamps/jobs/222367539)
  • warn: PR has multiple commits
  • show info message when all tests have passed
  • PR from master branch (source branch should starts from ghXXX_)
  • detect "Merge remote-tracking branch 'refs/remotes/php-coder/master'"
  • after modifying css/js files, Url.RESOURCES_VERSION should be bumped
  • warn about pull request to non-master branch (?)
  • error about space-only hunks
@@ -1031,7 +1031,7 @@
                <system>GitHub</system>
                <url>https://github.com/php-coder/mystamps/issues</url>
        </issueManagement>
-
+
        <ciManagement>
                <system>Travis CI</system>
                <url>https://travis-ci.org/php-coder/mystamps</url>
  • error about maven dependencies with explicit version (not a property)
<dependency>
    <groupId>javax.validation</groupId>
    <artifactId>validation-api</artifactId>
    <version>1.1.0.Final</version>
</dependency>
  • codenarc: detect checks that always should be ignored
  • cs/pmd/codenarc/findbugs: suggest a way of ignoring error (or documentation on wiki is enough?)
  • robotframework: try to findout the test case and use it for highlighting line numbers
  • surefire plugin: try to findout the test case and use it for highlighting line numbers
  • failsafe plugin: try to findout the test case and use it for highlighting line numbers
  • pass file/line to fail()
  • warn: code was modified but there are no modifications in tests
  • warn: commit message should not have Fixes # comment (see also https://help.github.com/articles/closing-issues-via-commit-messages/)
  • warn: PR description should have Addressed to # comment
  • add documentation
  • filter Build info/System info/Driver info from robotframework message
  • more strict check forUrl.RESOURCES_VERSION (check that user modified not just a Url file but the exact this constant)
  • sortpom-maven-plugin, remove pwd: The file /home/travis/build/php-coder/mystamps/pom.xml is not sorted
  • make it link: You can read how to do it here: https://davidwalsh.name/squash-commits-git

Follow-up to #536
Pull request to see this in action: #533

Metadata

Metadata

Assignees

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions