/category/add: deny "add" and "list" as category names

[php-coder]

Steps to reproduce:

• login as a user
• create category with name "add" (or "list")

Expected result:

• error message is shown because of invalid name

Actual result:

• category has been created and user were redirected to the /category/add (or /category/list) page

[benjiyue]

I'll take this

[php-coder]

I suggest to add validator DenyValues and pass disallowed values into it:

@DenyValues({"add", "list"})
private String name;

[php-coder]

I forgot to mention that you can use @ExistingActivationKey as an example:

• ExistingActivationKey.java
• ExistingActivationKeyValidator.java

If you want some theory about this, here is a link to documentation:

• Creating custom constraints
• Java Bean Validation Basics

[benjiyue]

Thus far I have written this much: benjiyue@b1fa3a9

But this fails compilation with the following errors:
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /Users/benjaminyue/Downloads/mystamps/src/main/java/ru/mystamps/web/model/AddCategoryForm.java:[88,21] cannot find symbol
symbol: method value()
location: @interface ru.mystamps.web.validation.jsr303.DenyValues
[INFO] 1 error
[INFO] -------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 3.850 s
[INFO] Finished at: 2017-04-14T16:44:29-04:00
[INFO] Final Memory: 42M/307M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile (default-compile) on project mystamps: Compilation failure
[ERROR] /Users/benjaminyue/Downloads/mystamps/src/main/java/ru/mystamps/web/model/AddCategoryForm.java:[88,21] cannot find symbol
[ERROR] symbol: method value()
[ERROR] location: @interface ru.mystamps.web.validation.jsr303.DenyValues
[ERROR] -> [Help 1]

Any pointers on what's wrong?

[php-coder]

Any pointers on what's wrong?

You need to add String value() to DenyValues class. After that inside of DenyValuesValidator you will be able to invoke annotation.value() to get the values passed into the annotation (@DenyValues({"add", "list"})). With this approach you won't need to hardcode these values.

[php-coder]

P.S. We have used this approach already:

• mystamps/src/main/java/ru/mystamps/web/model/AddImageForm.java

  Line 52 in be8d102

  @MaxFileSize(value = MAX_IMAGE_SIZE, unit = Unit.Kbytes, groups = Group.Level4.class)

• mystamps/src/main/java/ru/mystamps/web/validation/jsr303/MaxFileSize.java

  Line 46 in be8d102

  long value();

• mystamps/src/main/java/ru/mystamps/web/validation/jsr303/MaxFileSizeValidator.java

  Line 33 in be8d102

  maxFileSizeInBytes = annotation.value() * annotation.unit().getSize();

[php-coder]

@benjiyue Was it you who created categories "add" and "list" on my-stamp.ru site? Why did you create them? :)