Skip to content

Commit c82ab3a

Browse files
committed
TransactionParticipantServiceImpl: use NOPLogger for unit tests to reduce output to console.
No functional changes.
1 parent 5a4d48e commit c82ab3a

File tree

3 files changed

+12
-7
lines changed

3 files changed

+12
-7
lines changed

src/main/java/ru/mystamps/web/config/ServicesConfig.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,10 @@ public StampsCatalogService getGibbonsCatalogService() {
210210

211211
@Bean
212212
public TransactionParticipantService getTransactionParticipantService() {
213-
return new TransactionParticipantServiceImpl(daoConfig.getTransactionParticipantDao());
213+
return new TransactionParticipantServiceImpl(
214+
LoggerFactory.getLogger(TransactionParticipantServiceImpl.class),
215+
daoConfig.getTransactionParticipantDao()
216+
);
214217
}
215218

216219
}

src/main/java/ru/mystamps/web/service/TransactionParticipantServiceImpl.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
import org.apache.commons.lang3.Validate;
2323

2424
import org.slf4j.Logger;
25-
import org.slf4j.LoggerFactory;
2625

2726
import org.springframework.transaction.annotation.Transactional;
2827

@@ -38,9 +37,8 @@
3837

3938
@RequiredArgsConstructor
4039
public class TransactionParticipantServiceImpl implements TransactionParticipantService {
41-
private static final Logger LOG =
42-
LoggerFactory.getLogger(TransactionParticipantServiceImpl.class);
4340

41+
private final Logger log;
4442
private final TransactionParticipantDao transactionParticipantDao;
4543

4644
@Override
@@ -56,7 +54,7 @@ public void add(AddParticipantDto dto) {
5654

5755
transactionParticipantDao.add(participant);
5856

59-
LOG.info("Participant with name '{}' has been created", participant.getName());
57+
log.info("Participant with name '{}' has been created", participant.getName());
6058
}
6159

6260
@Override

src/test/groovy/ru/mystamps/web/service/TransactionParticipantServiceImplTest.groovy

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@
1717
*/
1818
package ru.mystamps.web.service
1919

20+
import org.slf4j.helpers.NOPLogger
21+
2022
import spock.lang.Specification
2123

2224
import ru.mystamps.web.dao.TransactionParticipantDao
@@ -28,8 +30,10 @@ import ru.mystamps.web.controller.dto.AddParticipantForm
2830
class TransactionParticipantServiceImplTest extends Specification {
2931

3032
private final TransactionParticipantDao transactionParticipantDao = Mock()
31-
private final TransactionParticipantService service =
32-
new TransactionParticipantServiceImpl(transactionParticipantDao)
33+
private final TransactionParticipantService service = new TransactionParticipantServiceImpl(
34+
NOPLogger.NOP_LOGGER,
35+
transactionParticipantDao
36+
)
3337

3438
//
3539
// Tests for add()

0 commit comments

Comments
 (0)