StampsCatalogServiceImpl: use NOPLogger for unit tests to reduce output to console.

No functional changes.

Author: php-coder

src/main/java/ru/mystamps/web/config/ServicesConfig.java

@@ -174,22 +174,38 @@ public UserService getUserService() {
 
 	@Bean
 	public StampsCatalogService getMichelCatalogService() {
-		return new StampsCatalogServiceImpl("Michel", daoConfig.getMichelCatalogDao());
+		return new StampsCatalogServiceImpl(
+			LoggerFactory.getLogger(StampsCatalogServiceImpl.class),
+			"Michel",
+			daoConfig.getMichelCatalogDao()
+		);
 	}
 
 	@Bean
 	public StampsCatalogService getScottCatalogService() {
-		return new StampsCatalogServiceImpl("Scott", daoConfig.getScottCatalogDao());
+		return new StampsCatalogServiceImpl(
+			LoggerFactory.getLogger(StampsCatalogServiceImpl.class),
+			"Scott",
+			daoConfig.getScottCatalogDao()
+		);
 	}
 
 	@Bean
 	public StampsCatalogService getYvertCatalogService() {
-		return new StampsCatalogServiceImpl("Yvert", daoConfig.getYvertCatalogDao());
+		return new StampsCatalogServiceImpl(
+			LoggerFactory.getLogger(StampsCatalogServiceImpl.class),
+			"Yvert",
+			daoConfig.getYvertCatalogDao()
+		);
 	}
 
 	@Bean
 	public StampsCatalogService getGibbonsCatalogService() {
-		return new StampsCatalogServiceImpl("Gibbons", daoConfig.getGibbonsCatalogDao());
+		return new StampsCatalogServiceImpl(
+			LoggerFactory.getLogger(StampsCatalogServiceImpl.class),
+			"Gibbons",
+			daoConfig.getGibbonsCatalogDao()
+		);
 	}
 
 	@Bean

src/main/java/ru/mystamps/web/service/StampsCatalogServiceImpl.java

@@ -23,7 +23,6 @@
 import org.apache.commons.lang3.Validate;
 
 import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 
 import org.springframework.transaction.annotation.Transactional;
 
@@ -36,8 +35,8 @@
 
 @RequiredArgsConstructor
 public class StampsCatalogServiceImpl implements StampsCatalogService {
-	private static final Logger LOG = LoggerFactory.getLogger(StampsCatalogServiceImpl.class);
 
+	private final Logger log;
 	private final String catalogName;
 	private final StampsCatalogDao stampsCatalogDao;
 
@@ -51,7 +50,7 @@ public void add(Set<String> catalogNumbers) {
 		List<String> insertedNumbers = stampsCatalogDao.add(catalogNumbers);
 
 		if (!insertedNumbers.isEmpty()) {
-			LOG.info("{} numbers {} were created", catalogName, insertedNumbers);
+			log.info("{} numbers {} were created", catalogName, insertedNumbers);
 		}
 	}
 
@@ -65,7 +64,7 @@ public void addToSeries(Integer seriesId, Set<String> catalogNumbers) {
 
 		stampsCatalogDao.addToSeries(seriesId, catalogNumbers);
 
-		LOG.info("Series #{}: {} numbers {} were added", seriesId, catalogName, catalogNumbers);
+		log.info("Series #{}: {} numbers {} were added", seriesId, catalogName, catalogNumbers);
 	}
 
 	@Override

src/test/groovy/ru/mystamps/web/service/StampsCatalogServiceImplTest.groovy

@@ -17,6 +17,8 @@
  */
 package ru.mystamps.web.service
 
+import org.slf4j.helpers.NOPLogger
+
 import spock.lang.Specification
 
 import ru.mystamps.web.dao.StampsCatalogDao
@@ -26,7 +28,11 @@ class StampsCatalogServiceImplTest extends Specification {
 
 	private final StampsCatalogDao stampsCatalogDao = Mock()
 
-	private final StampsCatalogService service = new StampsCatalogServiceImpl('TestCatalog', stampsCatalogDao)
+	private final StampsCatalogService service = new StampsCatalogServiceImpl(
+		NOPLogger.NOP_LOGGER,
+		'TestCatalog',
+		stampsCatalogDao
+	)
 
 	//
 	// Tests for add()