UserServiceImpl: use NOPLogger for unit tests to reduce output to console.

No functional changes.

Author: php-coder

src/main/java/ru/mystamps/web/config/ServicesConfig.java

@@ -152,6 +152,7 @@ public SiteService getSiteService() {
 	@Bean
 	public UserService getUserService() {
 		return new UserServiceImpl(
+			LoggerFactory.getLogger(UserServiceImpl.class),
 			daoConfig.getUserDao(),
 			getUsersActivationService(),
 			getCollectionService(),

src/main/java/ru/mystamps/web/service/UserServiceImpl.java

@@ -24,7 +24,6 @@
 import org.apache.commons.lang3.Validate;
 
 import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 
 import org.springframework.transaction.annotation.Transactional;
 
@@ -43,8 +42,7 @@
 @RequiredArgsConstructor
 public class UserServiceImpl implements UserService {
 
-	private static final Logger LOG = LoggerFactory.getLogger(UserServiceImpl.class);
-	
+	private final Logger log;
 	private final UserDao userDao;
 	private final UsersActivationService usersActivationService;
 	private final CollectionService collectionService;
@@ -71,7 +69,7 @@ public void registerUser(ActivateAccountDto dto) {
 		String activationKey = dto.getActivationKey();
 		UsersActivationDto activation = usersActivationService.findByActivationKey(activationKey);
 		if (activation == null) {
-			LOG.warn("Cannot find registration request for activation key '{}'", activationKey);
+			log.warn("Cannot find registration request for activation key '{}'", activationKey);
 			return;
 		}
 
@@ -95,7 +93,7 @@ public void registerUser(ActivateAccountDto dto) {
 		Integer id = userDao.add(user);
 		usersActivationService.remove(activationKey);
 
-		LOG.info("User #{} has been created ({})", id, user);
+		log.info("User #{} has been created ({})", id, user);
 
 		collectionService.createCollection(id, user.getLogin());
 	}

src/test/groovy/ru/mystamps/web/service/UserServiceImplTest.groovy

@@ -21,6 +21,8 @@ import org.springframework.security.crypto.password.PasswordEncoder
 
 import spock.lang.Specification
 
+import org.slf4j.helpers.NOPLogger
+
 import ru.mystamps.web.dao.UserDao
 import ru.mystamps.web.dao.dto.AddUserDbDto
 import ru.mystamps.web.dao.dto.UserDetails
@@ -55,7 +57,13 @@ class UserServiceImplTest extends Specification {
 		activationForm.setName(user.name)
 		activationForm.setActivationKey(TestObjects.TEST_ACTIVATION_KEY)
 
-		service = new UserServiceImpl(userDao, usersActivationService, collectionService, encoder)
+		service = new UserServiceImpl(
+			NOPLogger.NOP_LOGGER,
+			userDao,
+			usersActivationService,
+			collectionService,
+			encoder
+		)
 	}
 
 	//