Skip to content

Commit ae6cd4f

Browse files
committed
SeriesServiceImpl: use NOPLogger for unit tests to reduce output to console.
No functional changes.
1 parent 6337b84 commit ae6cd4f

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

src/main/java/ru/mystamps/web/config/ServicesConfig.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -129,6 +129,7 @@ public ReportService getReportService() {
129129
@Bean
130130
public SeriesService getSeriesService() {
131131
return new SeriesServiceImpl(
132+
LoggerFactory.getLogger(SeriesServiceImpl.class),
132133
daoConfig.getSeriesDao(),
133134
getImageService(),
134135
getMichelCatalogService(),

src/main/java/ru/mystamps/web/service/SeriesServiceImpl.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
import org.apache.commons.lang3.Validate;
2626

2727
import org.slf4j.Logger;
28-
import org.slf4j.LoggerFactory;
2928

3029
import org.springframework.transaction.annotation.Transactional;
3130

@@ -53,8 +52,8 @@
5352
@SuppressWarnings({ "PMD.TooManyMethods", "PMD.AvoidDuplicateLiterals" })
5453
@RequiredArgsConstructor
5554
public class SeriesServiceImpl implements SeriesService {
56-
private static final Logger LOG = LoggerFactory.getLogger(SeriesServiceImpl.class);
5755

56+
private final Logger log;
5857
private final SeriesDao seriesDao;
5958
private final ImageService imageService;
6059
private final StampsCatalogService michelCatalogService;
@@ -162,7 +161,7 @@ public Integer add(AddSeriesDto dto, Integer userId, boolean userCanAddComments)
162161
throw ex;
163162
}
164163

165-
LOG.info("Series #{} has been created ({})", id, series);
164+
log.info("Series #{} has been created ({})", id, series);
166165

167166
return id;
168167
}
@@ -188,7 +187,7 @@ public void addImageToSeries(AddImageDto dto, Integer seriesId, Integer userId)
188187
throw ex;
189188
}
190189

191-
LOG.info(
190+
log.info(
192191
"Image #{} has been added to series #{} by user #{}",
193192
imageId,
194193
seriesId,

src/test/groovy/ru/mystamps/web/service/SeriesServiceImplTest.groovy

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@ import org.springframework.web.multipart.MultipartFile
2222
import spock.lang.Specification
2323
import spock.lang.Unroll
2424

25+
import org.slf4j.helpers.NOPLogger
26+
2527
import ru.mystamps.web.dao.SeriesDao
2628
import ru.mystamps.web.dao.dto.AddSeriesDbDto
2729
import ru.mystamps.web.dao.dto.Currency
@@ -66,6 +68,7 @@ class SeriesServiceImplTest extends Specification {
6668
imageService.save(_) >> TestObjects.createImageInfoDto()
6769

6870
service = new SeriesServiceImpl(
71+
NOPLogger.NOP_LOGGER,
6972
seriesDao,
7073
imageService,
7174
michelCatalogService,

0 commit comments

Comments
 (0)