Skip to content

Commit 94de55f

Browse files
committed
WhenAdminAddSeries,WhenUserAddSeries: combine together test cases for catalog numbers.
-michelNumbersShouldRejectInvalidValues -scottNumbersShouldRejectInvalidValues -yvertNumbersShouldRejectInvalidValues -gibbonsNumbersShouldRejectInvalidValues +catalogNumbersShouldRejectInvalidValues No functional changes.
1 parent 67a8f62 commit 94de55f

File tree

2 files changed

+10
-56
lines changed

2 files changed

+10
-56
lines changed

src/test/java/ru/mystamps/web/tests/cases/WhenAdminAddSeries.java

Lines changed: 5 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -181,42 +181,19 @@ public void quantityShouldNotBeGreaterThanLimit() {
181181
}
182182

183183
@Test(groups = "invalid", dependsOnGroups = "std", dataProvider = "invalidCatalogNumbers")
184-
public void michelNumbersShouldRejectInvalidValues(String numbers, String msg) {
184+
public void catalogNumbersShouldRejectInvalidValues(String numbers, String msg) {
185185
page.showCatalogNumbers();
186-
page.fillMichelNumbers(numbers);
187-
188-
page.submit();
189186

190-
assertThat(page).field("michelNumbers").hasError(msg);
191-
}
192-
193-
@Test(groups = "invalid", dependsOnGroups = "std", dataProvider = "invalidCatalogNumbers")
194-
public void scottNumbersShouldRejectInvalidValues(String numbers, String msg) {
195-
page.showCatalogNumbers();
187+
page.fillMichelNumbers(numbers);
196188
page.fillScottNumbers(numbers);
197-
198-
page.submit();
199-
200-
assertThat(page).field("scottNumbers").hasError(msg);
201-
}
202-
203-
@Test(groups = "invalid", dependsOnGroups = "std", dataProvider = "invalidCatalogNumbers")
204-
public void yvertNumbersShouldRejectInvalidValues(String numbers, String msg) {
205-
page.showCatalogNumbers();
206189
page.fillYvertNumbers(numbers);
207-
208-
page.submit();
209-
210-
assertThat(page).field("yvertNumbers").hasError(msg);
211-
}
212-
213-
@Test(groups = "invalid", dependsOnGroups = "std", dataProvider = "invalidCatalogNumbers")
214-
public void gibbonsNumbersShouldRejectInvalidValues(String numbers, String msg) {
215-
page.showCatalogNumbers();
216190
page.fillGibbonsNumbers(numbers);
217191

218192
page.submit();
219193

194+
assertThat(page).field("michelNumbers").hasError(msg);
195+
assertThat(page).field("scottNumbers").hasError(msg);
196+
assertThat(page).field("yvertNumbers").hasError(msg);
220197
assertThat(page).field("gibbonsNumbers").hasError(msg);
221198
}
222199

src/test/java/ru/mystamps/web/tests/cases/WhenUserAddSeries.java

Lines changed: 5 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -176,42 +176,19 @@ public void quantityShouldNotBeGreaterThanLimit() {
176176
}
177177

178178
@Test(groups = "invalid", dependsOnGroups = "std", dataProvider = "invalidCatalogNumbers")
179-
public void michelNumbersShouldRejectInvalidValues(String numbers, String msg) {
179+
public void catalogNumbersShouldRejectInvalidValues(String numbers, String msg) {
180180
page.showCatalogNumbers();
181-
page.fillMichelNumbers(numbers);
182-
183-
page.submit();
184181

185-
assertThat(page).field("michelNumbers").hasError(msg);
186-
}
187-
188-
@Test(groups = "invalid", dependsOnGroups = "std", dataProvider = "invalidCatalogNumbers")
189-
public void scottNumbersShouldRejectInvalidValues(String numbers, String msg) {
190-
page.showCatalogNumbers();
182+
page.fillMichelNumbers(numbers);
191183
page.fillScottNumbers(numbers);
192-
193-
page.submit();
194-
195-
assertThat(page).field("scottNumbers").hasError(msg);
196-
}
197-
198-
@Test(groups = "invalid", dependsOnGroups = "std", dataProvider = "invalidCatalogNumbers")
199-
public void yvertNumbersShouldRejectInvalidValues(String numbers, String msg) {
200-
page.showCatalogNumbers();
201184
page.fillYvertNumbers(numbers);
202-
203-
page.submit();
204-
205-
assertThat(page).field("yvertNumbers").hasError(msg);
206-
}
207-
208-
@Test(groups = "invalid", dependsOnGroups = "std", dataProvider = "invalidCatalogNumbers")
209-
public void gibbonsNumbersShouldRejectInvalidValues(String numbers, String msg) {
210-
page.showCatalogNumbers();
211185
page.fillGibbonsNumbers(numbers);
212186

213187
page.submit();
214188

189+
assertThat(page).field("michelNumbers").hasError(msg);
190+
assertThat(page).field("scottNumbers").hasError(msg);
191+
assertThat(page).field("yvertNumbers").hasError(msg);
215192
assertThat(page).field("gibbonsNumbers").hasError(msg);
216193
}
217194

0 commit comments

Comments
 (0)