Skip to content

Commit 67a8f62

Browse files
committed
WhenAdminAddSeries,WhenUserAddSeries: combine together test cases for catalog numbers.
-michelNumbersShouldAcceptValidValues -scottNumbersShouldAcceptValidValues -yvertNumbersShouldAcceptValidValues -gibbonsNumbersShouldAcceptValidValues +catalogNumbersShouldAcceptValidValues No functional changes.
1 parent b2eb7d0 commit 67a8f62

File tree

2 files changed

+10
-56
lines changed

2 files changed

+10
-56
lines changed

src/test/java/ru/mystamps/web/tests/cases/WhenAdminAddSeries.java

Lines changed: 5 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -133,42 +133,19 @@ public void shouldHaveStandardStructure() {
133133
}
134134

135135
@Test(groups = "valid", dependsOnGroups = "std", dataProvider = "validCatalogNumbers")
136-
public void michelNumbersShouldAcceptValidValues(String numbers, Object whatever) {
136+
public void catalogNumbersShouldAcceptValidValues(String numbers, Object whatever) {
137137
page.showCatalogNumbers();
138-
page.fillMichelNumbers(numbers);
139-
140-
page.submit();
141138

142-
assertThat(page).field("michelNumbers").hasNoError();
143-
}
144-
145-
@Test(groups = "valid", dependsOnGroups = "std", dataProvider = "validCatalogNumbers")
146-
public void scottNumbersShouldAcceptValidValues(String numbers, Object whatever) {
147-
page.showCatalogNumbers();
139+
page.fillMichelNumbers(numbers);
148140
page.fillScottNumbers(numbers);
149-
150-
page.submit();
151-
152-
assertThat(page).field("scottNumbers").hasNoError();
153-
}
154-
155-
@Test(groups = "valid", dependsOnGroups = "std", dataProvider = "validCatalogNumbers")
156-
public void yvertNumbersShouldAcceptValidValues(String numbers, Object whatever) {
157-
page.showCatalogNumbers();
158141
page.fillYvertNumbers(numbers);
159-
160-
page.submit();
161-
162-
assertThat(page).field("yvertNumbers").hasNoError();
163-
}
164-
165-
@Test(groups = "valid", dependsOnGroups = "std", dataProvider = "validCatalogNumbers")
166-
public void gibbonsNumbersShouldAcceptValidValues(String numbers, Object whatever) {
167-
page.showCatalogNumbers();
168142
page.fillGibbonsNumbers(numbers);
169143

170144
page.submit();
171145

146+
assertThat(page).field("michelNumbers").hasNoError();
147+
assertThat(page).field("scottNumbers").hasNoError();
148+
assertThat(page).field("yvertNumbers").hasNoError();
172149
assertThat(page).field("gibbonsNumbers").hasNoError();
173150
}
174151

src/test/java/ru/mystamps/web/tests/cases/WhenUserAddSeries.java

Lines changed: 5 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -128,42 +128,19 @@ public void shouldHaveStandardStructure() {
128128
}
129129

130130
@Test(groups = "valid", dependsOnGroups = "std", dataProvider = "validCatalogNumbers")
131-
public void michelNumbersShouldAcceptValidValues(String numbers, Object whatever) {
131+
public void catalogNumbersShouldAcceptValidValues(String numbers, Object whatever) {
132132
page.showCatalogNumbers();
133-
page.fillMichelNumbers(numbers);
134-
135-
page.submit();
136133

137-
assertThat(page).field("michelNumbers").hasNoError();
138-
}
139-
140-
@Test(groups = "valid", dependsOnGroups = "std", dataProvider = "validCatalogNumbers")
141-
public void scottNumbersShouldAcceptValidValues(String numbers, Object whatever) {
142-
page.showCatalogNumbers();
134+
page.fillMichelNumbers(numbers);
143135
page.fillScottNumbers(numbers);
144-
145-
page.submit();
146-
147-
assertThat(page).field("scottNumbers").hasNoError();
148-
}
149-
150-
@Test(groups = "valid", dependsOnGroups = "std", dataProvider = "validCatalogNumbers")
151-
public void yvertNumbersShouldAcceptValidValues(String numbers, Object whatever) {
152-
page.showCatalogNumbers();
153136
page.fillYvertNumbers(numbers);
154-
155-
page.submit();
156-
157-
assertThat(page).field("yvertNumbers").hasNoError();
158-
}
159-
160-
@Test(groups = "valid", dependsOnGroups = "std", dataProvider = "validCatalogNumbers")
161-
public void gibbonsNumbersShouldAcceptValidValues(String numbers, Object whatever) {
162-
page.showCatalogNumbers();
163137
page.fillGibbonsNumbers(numbers);
164138

165139
page.submit();
166140

141+
assertThat(page).field("michelNumbers").hasNoError();
142+
assertThat(page).field("scottNumbers").hasNoError();
143+
assertThat(page).field("yvertNumbers").hasNoError();
167144
assertThat(page).field("gibbonsNumbers").hasNoError();
168145
}
169146

0 commit comments

Comments
 (0)