Skip to content

Commit 7ec1556

Browse files
committed
DatabaseImagePersistenceStrategy use NOPLogger for unit tests to reduce output to console.
No functional changes.
1 parent c82ab3a commit 7ec1556

File tree

3 files changed

+18
-10
lines changed

3 files changed

+18
-10
lines changed

src/main/java/ru/mystamps/web/config/StrategiesConfig.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@
1717
*/
1818
package ru.mystamps.web.config;
1919

20+
import org.slf4j.LoggerFactory;
21+
2022
import org.springframework.context.annotation.Bean;
2123
import org.springframework.context.annotation.Configuration;
2224
import org.springframework.context.annotation.Profile;
@@ -42,7 +44,10 @@ class DbStrategiesConfig implements StrategiesConfig {
4244
@Bean
4345
@Override
4446
public ImagePersistenceStrategy getImagePersistenceStrategy() {
45-
return new DatabaseImagePersistenceStrategy(daoConfig.getImageDataDao());
47+
return new DatabaseImagePersistenceStrategy(
48+
LoggerFactory.getLogger(DatabaseImagePersistenceStrategy.class),
49+
daoConfig.getImageDataDao()
50+
);
4651
}
4752

4853
}

src/main/java/ru/mystamps/web/service/DatabaseImagePersistenceStrategy.java

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
import javax.annotation.PostConstruct;
2323

2424
import org.slf4j.Logger;
25-
import org.slf4j.LoggerFactory;
2625

2726
import org.springframework.web.multipart.MultipartFile;
2827

@@ -37,14 +36,13 @@
3736

3837
@RequiredArgsConstructor
3938
public class DatabaseImagePersistenceStrategy implements ImagePersistenceStrategy {
40-
private static final Logger LOG =
41-
LoggerFactory.getLogger(DatabaseImagePersistenceStrategy.class);
4239

40+
private final Logger log;
4341
private final ImageDataDao imageDataDao;
4442

4543
@PostConstruct
4644
public void init() {
47-
LOG.info("Images will be saved into in-memory database");
45+
log.info("Images will be saved into in-memory database");
4846
}
4947

5048
@Override
@@ -56,7 +54,7 @@ public void save(MultipartFile file, ImageInfoDto image) {
5654
imageData.setPreview(false);
5755

5856
Integer id = imageDataDao.add(imageData);
59-
LOG.info("Image #{}: meta data has been saved to #{}", image.getId(), id);
57+
log.info("Image #{}: meta data has been saved to #{}", image.getId(), id);
6058

6159
} catch (IOException e) {
6260
// throw RuntimeException for rolling back transaction
@@ -73,14 +71,14 @@ public void savePreview(byte[] data, ImageInfoDto image) {
7371

7472
imageDataDao.add(imageData);
7573

76-
LOG.info("Image #{}: preview has been saved", image.getId());
74+
log.info("Image #{}: preview has been saved", image.getId());
7775
}
7876

7977
@Override
8078
public ImageDto get(ImageInfoDto image) {
8179
DbImageDto imageDto = imageDataDao.findByImageId(image.getId(), false);
8280
if (imageDto == null) {
83-
LOG.warn("Image #{}: content not found", image.getId());
81+
log.warn("Image #{}: content not found", image.getId());
8482
return null;
8583
}
8684

@@ -91,7 +89,7 @@ public ImageDto get(ImageInfoDto image) {
9189
public ImageDto getPreview(ImageInfoDto image) {
9290
DbImageDto imageDto = imageDataDao.findByImageId(image.getId(), true);
9391
if (imageDto == null) {
94-
LOG.info("Image #{}: preview not found", image.getId());
92+
log.info("Image #{}: preview not found", image.getId());
9593
return null;
9694
}
9795

src/test/groovy/ru/mystamps/web/service/DatabaseImagePersistenceStrategyTest.groovy

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@
1717
*/
1818
package ru.mystamps.web.service
1919

20+
import org.slf4j.helpers.NOPLogger
21+
2022
import org.springframework.web.multipart.MultipartFile
2123

2224
import spock.lang.Specification
@@ -34,7 +36,10 @@ class DatabaseImagePersistenceStrategyTest extends Specification {
3436
private final MultipartFile multipartFile = Mock()
3537
private final ImageInfoDto imageInfoDto = TestObjects.createImageInfoDto()
3638

37-
private final ImagePersistenceStrategy strategy = new DatabaseImagePersistenceStrategy(imageDataDao)
39+
private final ImagePersistenceStrategy strategy = new DatabaseImagePersistenceStrategy(
40+
NOPLogger.NOP_LOGGER,
41+
imageDataDao
42+
)
3843

3944
//
4045
// Tests for save()

0 commit comments

Comments
 (0)