Skip to content

Commit 3ea17c3

Browse files
committed
SeriesSalesServiceImpl: use NOPLogger for unit tests to reduce output to console.
No functional changes.
1 parent 2ffc1a5 commit 3ea17c3

File tree

3 files changed

+12
-6
lines changed

3 files changed

+12
-6
lines changed

src/main/java/ru/mystamps/web/config/ServicesConfig.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,10 @@ public SeriesService getSeriesService() {
147147

148148
@Bean
149149
public SeriesSalesService getSeriesSalesService() {
150-
return new SeriesSalesServiceImpl(daoConfig.getSeriesSalesDao());
150+
return new SeriesSalesServiceImpl(
151+
LoggerFactory.getLogger(SeriesSalesServiceImpl.class),
152+
daoConfig.getSeriesSalesDao()
153+
);
151154
}
152155

153156
@Bean

src/main/java/ru/mystamps/web/service/SeriesSalesServiceImpl.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
import org.apache.commons.lang3.Validate;
2323

2424
import org.slf4j.Logger;
25-
import org.slf4j.LoggerFactory;
2625

2726
import org.springframework.transaction.annotation.Transactional;
2827

@@ -38,8 +37,7 @@
3837
@RequiredArgsConstructor
3938
public class SeriesSalesServiceImpl implements SeriesSalesService {
4039

41-
private static final Logger LOG = LoggerFactory.getLogger(SeriesSalesServiceImpl.class);
42-
40+
private final Logger log;
4341
private final SeriesSalesDao seriesSalesDao;
4442

4543
@Override
@@ -73,7 +71,7 @@ public void add(AddSeriesSalesDto dto, Integer seriesId, Integer userId) {
7371

7472
seriesSalesDao.add(sale);
7573

76-
LOG.info("Sale for series #{} has been added by user #{}", seriesId, userId);
74+
log.info("Sale for series #{} has been added by user #{}", seriesId, userId);
7775
}
7876

7977
}

src/test/groovy/ru/mystamps/web/service/SeriesSalesServiceImplTest.groovy

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@
1717
*/
1818
package ru.mystamps.web.service
1919

20+
import org.slf4j.helpers.NOPLogger
21+
2022
import spock.lang.Specification
2123
import spock.lang.Unroll
2224

@@ -30,7 +32,10 @@ import ru.mystamps.web.tests.DateUtils
3032
class SeriesSalesServiceImplTest extends Specification {
3133

3234
private final SeriesSalesDao seriesSalesDao = Mock()
33-
private final SeriesSalesService service = new SeriesSalesServiceImpl(seriesSalesDao)
35+
private final SeriesSalesService service = new SeriesSalesServiceImpl(
36+
NOPLogger.NOP_LOGGER,
37+
seriesSalesDao
38+
)
3439

3540
private AddSeriesSalesForm form
3641

0 commit comments

Comments
 (0)