WhenAdminAddSeries.catalogNumbersShouldRejectInvalidValues: port to Robot Framework.

Addressed to #530

No functional changes.

Author: php-coder

src/test/java/ru/mystamps/web/tests/cases/WhenAdminAddSeries.java

@@ -118,23 +118,6 @@ public void shouldHaveStandardStructure() {
 		checkStandardStructure();
 	}
 
-	@Test(groups = "invalid", dependsOnGroups = "std", dataProvider = "invalidCatalogNumbers")
-	public void catalogNumbersShouldRejectInvalidValues(String numbers, String msg) {
-		page.showCatalogNumbers();
-		
-		page.fillMichelNumbers(numbers);
-		page.fillScottNumbers(numbers);
-		page.fillYvertNumbers(numbers);
-		page.fillGibbonsNumbers(numbers);
-		
-		page.submit();
-		
-		assertThat(page).field("michelNumbers").hasError(msg);
-		assertThat(page).field("scottNumbers").hasError(msg);
-		assertThat(page).field("yvertNumbers").hasError(msg);
-		assertThat(page).field("gibbonsNumbers").hasError(msg);
-	}
-	
 	@Test(groups = "invalid", dependsOnGroups = "std", dataProvider = "invalidCatalogPrices")
 	public void catalogPricesShouldRejectInvalidValues(String price, String msg) {
 		page.showCatalogNumbers();
@@ -229,24 +212,6 @@ public void shouldAllowExistingCatalogNumbers() {
 		assertThat(nextPage.getGibbonsCatalogInfo()).isEqualTo("#" + existingGibbonsNumber);
 	}
 
-	@DataProvider(name = "invalidCatalogNumbers")
-	public Object[][] getInvalidCatalogNumbers() {
-		String expectedErrorMessage =
-			tr("ru.mystamps.web.validation.jsr303.CatalogNumbers.message");
-		
-		return new Object[][] {
-			{"t", expectedErrorMessage},
-			{"t,t", expectedErrorMessage},
-			{",1", expectedErrorMessage},
-			{"1,", expectedErrorMessage},
-			{"1,,2", expectedErrorMessage},
-			{"0", expectedErrorMessage},
-			{"05", expectedErrorMessage},
-			{"1,09", expectedErrorMessage},
-			{"10000", expectedErrorMessage}
-		};
-	}
-	
 	@DataProvider(name = "invalidCatalogPrices")
 	public Object[][] getInvalidCatalogPrices() {
 		String expectedErrorMessage = tr("ru.mystamps.web.validation.jsr303.Price.message");

src/test/robotframework/series/creation/validation.robot

@@ -30,6 +30,19 @@ Create series with empty image
 	Submit Form             id=add-series-form
 	Element Text Should Be  id=image.errors  File must not be empty
 
+Catalog numbers should reject invalid values
+	[Documentation]  Verify that fields with catalog numbers reject invalid values
+	[Template]       Invalid Catalog Numbers Should Be Rejected
+	t
+	t,t
+	,1
+	1,
+	1,,2
+	0
+	05
+	1,09
+	10000
+
 Create series with too long comment
 	[Documentation]                Verify validation of too long comment
 	${letter}=                     Set Variable  x
@@ -63,3 +76,17 @@ Log In As
 Log Out
 	[Documentation]  Log out current user
 	Submit Form      id=logout-form
+
+Invalid Catalog Numbers Should Be Rejected
+	[Documentation]         Test that specifying catalog numbers cause an error
+	[Arguments]             ${catalogNumbers}
+	Click Element           id=add-catalog-numbers-link
+	Input Text              id=michelNumbers  ${catalogNumbers}
+	Input Text              id=scottNumbers  ${catalogNumbers}
+	Input Text              id=yvertNumbers  ${catalogNumbers}
+	Input Text              id=gibbonsNumbers  ${catalogNumbers}
+	Submit Form             id=add-series-form
+	Element Text Should Be  id=michelNumbers.errors  Value must be comma delimited numbers
+	Element Text Should Be  id=scottNumbers.errors  Value must be comma delimited numbers
+	Element Text Should Be  id=yvertNumbers.errors  Value must be comma delimited numbers
+	Element Text Should Be  id=gibbonsNumbers.errors  Value must be comma delimited numbers