WhenAdminAddSeries.catalogNumbersShouldAcceptValidValues: port to Robot Framework.

Addressed to #530

No functional changes.

Author: php-coder

src/test/java/ru/mystamps/web/tests/cases/WhenAdminAddSeries.java

@@ -118,23 +118,6 @@ public void shouldHaveStandardStructure() {
 		checkStandardStructure();
 	}
 
-	@Test(groups = "valid", dependsOnGroups = "std", dataProvider = "validCatalogNumbers")
-	public void catalogNumbersShouldAcceptValidValues(String numbers, Object whatever) {
-		page.showCatalogNumbers();
-		
-		page.fillMichelNumbers(numbers);
-		page.fillScottNumbers(numbers);
-		page.fillYvertNumbers(numbers);
-		page.fillGibbonsNumbers(numbers);
-		
-		page.submit();
-		
-		assertThat(page).field("michelNumbers").hasNoError();
-		assertThat(page).field("scottNumbers").hasNoError();
-		assertThat(page).field("yvertNumbers").hasNoError();
-		assertThat(page).field("gibbonsNumbers").hasNoError();
-	}
-	
 	@Test(groups = "invalid", dependsOnGroups = "std", dataProvider = "invalidCatalogNumbers")
 	public void catalogNumbersShouldRejectInvalidValues(String numbers, String msg) {
 		page.showCatalogNumbers();
@@ -203,7 +186,7 @@ public void commentShouldBeStripedFromLeadingAndTrailingSpaces() {
 		assertThat(page).field("comment").hasValue("example comment");
 	}
 
-	@Test(groups = "logic", dependsOnGroups = { "std", "valid", "invalid", "misc" })
+	@Test(groups = "logic", dependsOnGroups = { "std", "invalid", "misc" })
 	public void shouldIgnoreDuplicatedCatalogNumbers() {
 		page.fillCategory(validCategoryName);
 		page.fillQuantity("2");
@@ -225,7 +208,7 @@ public void shouldIgnoreDuplicatedCatalogNumbers() {
 		assertThat(nextPage.getGibbonsCatalogInfo()).isEqualTo("#134, 135");
 	}
 
-	@Test(groups = "logic", dependsOnGroups = { "std", "valid", "invalid", "misc" })
+	@Test(groups = "logic", dependsOnGroups = { "std", "invalid", "misc" })
 	public void shouldAllowExistingCatalogNumbers() {
 		page.fillCategory(validCategoryName);
 		page.fillQuantity("2");
@@ -246,16 +229,6 @@ public void shouldAllowExistingCatalogNumbers() {
 		assertThat(nextPage.getGibbonsCatalogInfo()).isEqualTo("#" + existingGibbonsNumber);
 	}
 
-	@DataProvider(name = "validCatalogNumbers")
-	public Object[][] getValidCatalogNumbers() {
-		return new Object[][] {
-			{"7", null},
-			{"7,8", null},
-			{"71, 81, 91", null},
-			{"1000", null}
-		};
-	}
-	
 	@DataProvider(name = "invalidCatalogNumbers")
 	public Object[][] getInvalidCatalogNumbers() {
 		String expectedErrorMessage =

src/test/robotframework/series/creation/misc.robot

@@ -0,0 +1,54 @@
+*** Settings ***
+Documentation    Verify miscellaneous aspects of series creation
+Library          Selenium2Library
+Suite Setup      Before Test Suite
+Suite Teardown   After Test Suite
+Force Tags       series  misc
+
+*** Test Cases ***
+Catalog numbers should accept valid values
+	[Documentation]  Verify that fields with catalog numbers accept valid values
+	[Template]       Valid Catalog Numbers Should Be Accepted
+	7
+	7,8
+	71, 81, 91
+	1000
+
+*** Keywords ***
+Before Test Suite
+	[Documentation]                     Login as admin and go to create series page
+	Open Browser                        ${SITE_URL}  ${BROWSER}
+	Register Keyword To Run On Failure  Log Source
+	Log In As                           login=admin  password=test
+	Go To                               ${SITE_URL}/series/add
+
+After Test Suite
+	[Documentation]  Log out and close browser
+	Log Out
+	Close Browser
+
+Log In As
+	[Documentation]  Log in as a user
+	[Arguments]      ${login}  ${password}
+	Go To            ${SITE_URL}/account/auth
+	Input Text       id=login  ${login}
+	Input Password   id=password  ${password}
+	Submit Form      id=auth-account-form
+
+Log Out
+	[Documentation]  Log out current user
+	Submit Form      id=logout-form
+
+Valid Catalog Numbers Should Be Accepted
+	[Documentation]                  Test that specifying catalog numbers don't cause an error
+	[Arguments]                      ${catalogNumber}
+	Click Element                    id=add-catalog-numbers-link
+	Input Text                       id=michelNumbers  ${catalogNumber}
+	Input Text                       id=scottNumbers  ${catalogNumber}
+	Input Text                       id=yvertNumbers  ${catalogNumber}
+	Input Text                       id=gibbonsNumbers  ${catalogNumber}
+	Submit Form                      id=add-series-form
+	Page Should Not Contain Element  id=michelNumbers.errors
+	Page Should Not Contain Element  id=scottNumbers.errors
+	Page Should Not Contain Element  id=yvertNumbers.errors
+	Page Should Not Contain Element  id=gibbonsNumbers.errors