Support for simple cache #75
Conversation
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
============================================
- Coverage 41.6% 37.39% -4.21%
Complexity 183 183
============================================
Files 20 20
Lines 762 821 +59
============================================
- Hits 317 307 -10
- Misses 445 514 +69
Continue to review full report at Codecov.
|
src/DataCollector/ProxyFactory.php
Outdated
| } | ||
| } | ||
|
|
||
| protected function getProxyClass($namespace) |
| $this->originalObject = $originalObject; | ||
| } | ||
|
|
||
| public function create() |
There was a problem hiding this comment.
Use $originalObject as a function parameter and register the factory in the service.yml
src/DataCollector/ProxyFactory.php
Outdated
| * Create a proxy that handles logging better. | ||
| * | ||
| * @param string $class | ||
| * @param string $file where we store the proxy class |
src/DataCollector/ProxyFactory.php
Outdated
| return $proxyClass; | ||
| } | ||
|
|
||
| $content = <<<PROXY |
There was a problem hiding this comment.
Could we get_file_contents() this file instead? It will be easier to change and review.
|
sorry had no time for a review -.- |
|
No worries. I have 2 PRs open now. After that I think we should release a new version. What do you think? |
| @@ -27,14 +27,15 @@ | |||
| "php": "^5.6 || ^7.0", | |||
| "symfony/framework-bundle": "^2.7 || ^3.0", | |||
| "cache/taggable-cache": "^0.5", | |||
| "cache/session-handler": "^0.2" | |||
| "cache/session-handler": "^0.2", | |||
There was a problem hiding this comment.
we have stable version, why dont use them?
There was a problem hiding this comment.
It was not a part of this PR.
But here: #76
|
Sounds like a good idea |
Introducing the support for cache proxies instead for messing around with different types of recording pools like we did.
This will create a proxy file that extends the original pool. It is only used in development of course.