Skip to content

Adds an option to disable the data collector #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2017

Conversation

iainmckay
Copy link
Contributor

We need a way to disable the data collector as during development our app regularly runs out of memory because of how much data it collects. In our particular case we use a lot of annotations and doctrine is caching those in memcache. We end up running over our memory limit.

We don't get much value from the data collector so the option to disable solves the problem for us.

@Nyholm
Copy link
Member

Nyholm commented Jun 15, 2017

Thank you. I like this.
Can you make sure to fix the style issue?

@codecov-io
Copy link

codecov-io commented Jun 16, 2017

Codecov Report

Merging #73 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #73      +/-   ##
===========================================
+ Coverage     41.51%   41.6%   +0.08%     
- Complexity      181     183       +2     
===========================================
  Files            20      20              
  Lines           737     762      +25     
===========================================
+ Hits            306     317      +11     
- Misses          431     445      +14
Impacted Files Coverage Δ Complexity Δ
src/DependencyInjection/Configuration.php 97.76% <100%> (+0.14%) 11 <1> (+1) ⬆️
src/DependencyInjection/CacheExtension.php 93.5% <100%> (+0.26%) 19 <0> (+1) ⬆️
src/Cache/Recording/CachePool.php 13.33% <0%> (-2.06%) 22% <0%> (ø)
src/Cache/Recording/TaggablePool.php 0% <0%> (ø) 2% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00549bb...8788443. Read the comment docs.

@iainmckay
Copy link
Contributor Author

Fixed

@Nyholm Nyholm merged commit 3a0f534 into php-cache:master Jun 16, 2017
@Nyholm
Copy link
Member

Nyholm commented Jun 16, 2017

Thank you

@iainmckay iainmckay deleted the disable-data-collector-option branch June 16, 2017 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants