Skip to content

Make sure all types of cache supports prefix and tagging #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 29, 2017

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Mar 28, 2017

This will fix php-cache/issues#78

@codecov-io
Copy link

codecov-io commented Mar 28, 2017

Codecov Report

Merging #71 into master will increase coverage by 1.07%.
The diff coverage is 70.83%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #71      +/-   ##
============================================
+ Coverage     40.44%   41.51%   +1.07%     
- Complexity      176      181       +5     
============================================
  Files            19       20       +1     
  Lines           727      737      +10     
============================================
+ Hits            294      306      +12     
+ Misses          433      431       -2
Impacted Files Coverage Δ Complexity Δ
src/Cache/Recording/Factory.php 70.58% <ø> (-11.77%) 6 <0> (ø)
src/Routing/CachingRouter.php 10.86% <0%> (ø) 14 <0> (ø) ⬇️
src/DependencyInjection/Configuration.php 97.61% <100%> (+0.09%) 10 <0> (ø) ⬇️
src/Factory/SessionHandlerFactory.php 100% <100%> (ø) 2 <2> (ø) ⬇️
src/DependencyInjection/CacheExtension.php 93.24% <100%> (+0.09%) 18 <0> (ø) ⬇️
src/Factory/ValidationFactory.php 75% <50%> (-25%) 3 <3> (+1)
src/Factory/DoctrineBridgeFactory.php 75% <50%> (-25%) 3 <3> (+1)
src/Factory/RouterFactory.php 75% <75%> (ø) 3 <3> (?)
src/Cache/Recording/TaggablePool.php 0% <0%> (ø) 2% <0%> (ø) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f341bf...362a117. Read the comment docs.

@Nyholm Nyholm merged commit 3e6c761 into master Mar 29, 2017
@Nyholm Nyholm deleted the patch-prefix branch July 31, 2017 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prefix on cache services in Symfony bundle (annotation, serializer, etc.)
2 participants