Recommend caching COMPOSER_CACHE_DIR over vendor/ #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caching the vendor directory as-is could produce various unwanted and hard to debug problems. For example: - vendor/autoload* would not be dumped again based on new changes to code and composer.json configuration - vendor/installed.json would not be updated with changes to Composer version See this thread which caused github.com/actions/cache to recommend not caching vendor, but instead cache the Composer cache dir: actions/cache#32 (comment) which is based on travis-ci/travis-ci#4579 (comment)
|
Hi @hkdobrev , thanks so much for your PR. This is a very valid point you raise, and I will give it some proper attention. One thing that I would like to think about in the future is whether this repository can/should provide a simpler way to cache the dependencies, maybe as a custom command? Anyway, for now I will check and accept this PR as it contains some very important updates. |
g105b
approved these changes
May 9, 2020
g105b
pushed a commit
to php-actions/php-build
that referenced
this pull request
Mar 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caching the vendor directory as-is could produce various unwanted and hard to debug problems.
For example:
vendor/autoload*would not be dumped again based on new changes to code andcomposer.jsonconfigurationvendor/installed.jsonwould not be updated with changes to Composer versionSee this thread which caused github.com/actions/cache to recommend not caching vendor, but instead cache the Composer cache dir: actions/cache#32 (comment) which is based on travis-ci/travis-ci#4579 (comment)