Skip to content

fix: use ACTION_CONTAINER_WORKDIR if not empty #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2023
Merged

fix: use ACTION_CONTAINER_WORKDIR if not empty #108

merged 1 commit into from
Sep 13, 2023

Conversation

redjam13
Copy link
Contributor

@redjam13 redjam13 commented Sep 8, 2023 •
edited
Loading

This is currently setting --workdir to empty by default 🥴

(master seems broken since #103).

Resolves #107.

@g105b
Copy link
Member

g105b commented Sep 13, 2023

Oof, good catch! Thanks a lot for your contribution.

@g105b g105b merged commit 8a65f0d into php-actions:master Sep 13, 2023
@g105b
Copy link
Member

g105b commented Sep 13, 2023

@redjam13 and @gsdevme , I would love to hear your suggestions for how I can do proper testing for this kind of project, to prevent this kind of error being made in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsdevme gsdevme gsdevme approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docker: invalid reference format: repository name must be lowercase.
3 participants
@redjam13 @g105b @gsdevme