Composer unable to apply patches

[joz-cti]

This github action is unable to apply composer patches, the specific add on I am using is - https://github.com/cweagans/composer-patches
It is strange that if I use "composer install" instead of this package then composer can apply the patches.
The add on requires "patch" to be installed on the server, I can confirm this was installed on the Ubuntu OS.
Are there permission restriction on what this action can do? Perhaps it cannot write/update to the the file system?

[g105b]

Hi @joz-cti,

This isn't something I'm familiar with, but I'll look into it for you as soon as I can.

Any follow up information here would be useful, but I'll pick it up as soon as I get some time.

Cheers,
Greg.

[dschmidtadv]

composer-patches

I am facing the same issue.

[g105b]

Hi @joz-cti

I'm following up on this as the issue is still unresolved. Please could you help me by showing me the output of your failing workflow? I can't see any reason why this wouldn't work out of the box, as Ubuntu does indeed have diff and patch installed by default.

Thanks,
Greg.

[joz-cti]

Hi Greg, I will look into this tomorrow and provide you the log Joz

…

On Mon, 5 Sept 2022, 22:32 Greg Bowler, ***@***.***> wrote: Hi @joz-cti <https://github.com/joz-cti> I'm following up on this as the issue is still unresolved. Please could you help me by showing me the output of your failing workflow? I can't see any reason why this wouldn't work out of the box, as Ubuntu does indeed have diff and patch installed by default. Thanks, Greg. — Reply to this email directly, view it on GitHub <#62 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AUPGUUINSZAFNVFWY2PLHE3V4ZRG3ANCNFSM5CPDS6XQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[viktor-borysiuk]

Hi Greg,

I have the same issue with applying compose patches. I can share you the output message, perhaps will help you

patch '-p1' --no-backup-if-mismatch -d '<package_name>' < '<path_to_file_patch.patch'
sh: patch: not found

[g105b]

Interesting - it looks like this is run within sh rather than bash, and the patch command isn't available by default. I'll look into this on the example-composer repository and see if I can replicate, and once it's replicable it's fixable. Thanks for your input @viktor-borysiuk

[g105b]

I've added the help wanted label because I'm not sure how to fix this myself.

[pingevt]

@g105b - First, I'm no expert on Github actions, and could be completely off base, so take it for what its worth. But this is the rabbit trail I've gone down for looking into this.

• Sounds like patch command isn't found and I would assume this is a docker issue
• You're creating the docker image here: https://raw.githubusercontent.com/php-actions/php-build/cee5b9fa9fbc4c888e7a62bbb7b8eade18e3c56b/php-build.bash
• Looks like the base is only a php base image, not a composer base image
• Looking at a composer docker file (example) you can see they are explicitly installing patch in the first run command

So after that rabbit trail... I think adding patch at least to your docker image in the RUN apk command is the first place to start. However, I'm not sure how to test this locally.

Also, I guess I would also ask, why not use a composer docker image?

[pingevt]

@g105b

OK - I forked 2 of your repos, and I think I have this working.

Simply put, in your php-build.bash file in php-actions/php-build, I changed:

RUN apk add --update --no-cache zip git bash openssh"
to
RUN apk add --update --no-cache bash coreutils git make openssh patch unzip zip"

I added in a few others from composer's docker file.

I want to keep looking into this on my site to make sure it really is working.

[g105b]

Oh that looks a lot simpler than I thought. I'll make that change on php-build, unless you want to raise a PR for it, then we can test it for real on https://github.com/php-actions/example-composer

[pingevt]

Just added a PR. I worked on it a little more yesterday and is working for my case.

[g105b]

Will update this ticket later with the outcome of testing.

[g105b]

Hi - this looks to be working now on a test branch. Please can you give it a run by using this step in your workflow file:

      - name: Install dependencies
        uses: php-actions/composer@bluecadet