Feature request: Custom command arguments

[dgw]

I attempted to use a custom command with arguments:

[Symfony\Component\Console\Exception\CommandNotFoundException]
  Command "install --working-dir ./submodule --no-suggest --prefer-dist" is not defined.

The step configuration:

      - name: Install PHP dependencies
        uses: php-actions/composer@v1
        with:
          command: install
          args: --working-dir ./submodule --no-suggest --prefer-dist

Being able to use php-actions/composer with arguments would be nicer than our current workflow including shivammathur/setup-php, as this is a self-contained Docker action.

Note: I've had to redact the actual --working-dir value because the example is taken from an internal project at work, but the directory name should be irrelevant.

[g105b]

Thanks for opening this. I will look into this and report back after some testing.

[navarr]

Hi I've ran into a similar issue trying to use this action to generate an archive

[Symfony\Component\Console\Exception\CommandNotFoundException]  
  Command "archive --format=zip --dir=./build" is not defined.  

Trying to use the command as thus:

      - name: Generate Composer Artifact
        uses: php-actions/composer@v1
        with:
          command: archive --format=zip --dir=./build

(aside: Hi @dgw, fancy meeting you here)

[navarr]

I guess my question would be, are the quotes in entrypoint around $@ necessary? I believe these examples would work without them, and I'm not sure what scenarios they were added to avoid

[georgezim85]

Worked for me like this:

- name: Install Composer packages dependencies
  uses: php-actions/composer@v1
  with:
    command: composer
    args: install --no-suggest --prefer-dist

[g105b]

I'm currently trying to collate a bunch of use cases with example usages that I'll add to the readme file. Thanks to @georgezim85 for this one, I'll use this and give you credit.

If anyone else would like to provide suggestions for how they pass custom commands, please post it in here and I'll add your suggestions to the documentation.

[georgezim85]

Worked for me like this:

- name: Install Composer packages dependencies
  uses: php-actions/composer@v1
  with:
    command: composer
    args: install --no-suggest --prefer-dist

Thanks.
The way I made worked when I was running with act for testing locally

[g105b]

That's great. I didn't know about that project, I'm going to see if I can get it running with a few projects I'm working on.

[gvjacob]

Hello @g105b do you have an updated status on this issue? I still can't pass custom arguments to the command, specifically including a working directory for the install command.

[g105b]

@gvjacob I am planning on getting these issues resolved this week. Sorry to keep you waiting, i hate to not be there for the open source community but I have had a lot of project work from my employer which has left me with very little brain space for open source. It's something that I care about a lot, and will be getting through these issues very soon.

[gvjacob]

Thanks for getting back to me @g105b. Open source can feel like a second job so don't be too hard on yourself! You've done some wonderful work

[g105b]

Hey @gvjacob , @georgezim85, @navarr and @dgw ,

Thank you for being so patient with me. I now have more time to spend on open source contributions, and I am happy to say I have a solution for you.

I have used @dgw's original idea of using the args input parameter to pass arbitrary arguments. The way this has been implemented is by passing all of the inputs to the entrypoint script, whether they are set or not. This allows the entrypoint (bash) to do more logic on the individual known inputs before executing the command.

I'm releasing this as v2 in the next few hours, currently on master, so please go ahead and update your action yaml configuration. Feel free to report back here with how you get on.

Cheers,
Greg.