Add missing tests, make tests less "interactive", minor fixes #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@petebacondarwin : With this PR I think all comments from angular#9517 are taken care of. Except for the one about using the |
Add support for a configurable vertical scroll offset to `$anchorScroll`. The offset can be defined by a specific number of pixels, a callback function that returns the number of pixels on demand or a jqLite/JQuery wrapped DOM element whose height and position are used if it has fixed position. The offset algorithm takes into account items that are near the bottom of the page preventing over-zealous offset correction. Closes angular#9368 Closes angular#2070 Closes angular#9360
Add tests for <body> with border/margin/padding and boxSizing. Simplify and fix a couple of bugs.
Mock `getBoundingClientRect()` method of elements in tests, instead of relying on the browser to actually size and scroll the elements.
gkalpak
force-pushed
the
anchorScroll-offset
branch
from
fbe10a6 to
4e7569c
Compare
|
There is one failing test, because of this: Once it's merged, the test will pass. |
petebacondarwin
force-pushed
the
anchorScroll-offset
branch
2 times, most recently
from
41f6e7e to
f774412
Compare
|
Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a couple of bugs.
Simplified logic in a couple of places.
Added tests for
<body>with border/margin/padding/boxSizing.Refactored tests to make them less dependent from the actual interaction with the browser.