fix(plugin-nested-docs): fix bug in logic to determine if doc is a draft #12412
Conversation
The current approach fails to handle documents in collections that don't have versioning enabled. In these situations, `doc._status` is undefined, which causes the current logic to return `draft=true` and no children are resaved.
crcorbett
changed the title
| @@ -115,7 +115,7 @@ export const resaveChildren = | |||
| await resave({ | |||
| collection, | |||
| doc, | |||
| draft: doc._status === 'published' ? false : true, | |||
| draft: (!doc._status || doc._status === 'published') ? false : true, | |||
There was a problem hiding this comment.
I would typically check the collection config to see if versions.drafts is enabled. That said, I see how this would work also.
Good job!
Head branch was pushed to by a user without write access
|
Thanks @DanRibbens! I wasn't entirely sure if I was missing the bigger picture with this plugin, so pushed out a quick fix to begin the discussion. Glad to see I was on the right track. I've updated the PR to include your helpful suggestion regarding checking whether versioning is enabled on the collection, and added a note into the plugin docs regarding descendants not being updated when the parent is in a draft state. Hoping the note helps others find the issue faster in the future. Feel free to take or leave any of the changes — though I'm glad to finally contribute to Payload! |
The current approach fails to handle documents in collections that don't have versioning enabled. In these situations,
doc._statusis undefined, which causes the current logic to returndraft=trueand no children are resaved.Issue: #12411