Skip to content

First pass at adding login/link with Facebook support. #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2015

Conversation

gfosco
Copy link
Contributor

@gfosco gfosco commented Apr 13, 2015

No description provided.

@gfosco gfosco mentioned this pull request Apr 13, 2015
gfosco added a commit that referenced this pull request Apr 15, 2015
First pass at adding login/link with Facebook support.
@gfosco gfosco merged commit 6b61d66 into master Apr 15, 2015
@gfosco gfosco deleted the gFosco.user-linking branch April 15, 2015 01:39
@gfosco
Copy link
Contributor Author

gfosco commented Apr 23, 2015

What do you mean?

@kerkness
Copy link

Testing logInWithFacebook from this commit and have noted a couple of errors. If $expiration_date is not provided an error of Parse\DateTime is not included in ParseUser is produced.

If expiration date is provided then ParseClient::_request produces an invalid JSON response.

@kerkness
Copy link

I really don't think this is the right solution but this bandaid approach at least works for now.

https://github.com/kerkness/parse-php-sdk/commit/c4ae87083d3d29b535275b053be02b3e2c5a2102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants