Made properties inside ParseObject that implement \Parse\Internal\Encoda... #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odable to be encodable. This fixes the issue where the instances of ParseGeoPoint were not being encoded.
|
Did this pass tests? |
|
Yes, it did. The results were: OK (235 tests, 726 assertions), no failures. |
gfosco
added a commit
that referenced
this pull request
Oct 10, 2014
Made properties inside ParseObject that implement \Parse\Internal\Encoda...
|
Thanks for fixing this! :) |
|
Awesome, thanks to you for letting me contribute to this project, love Parse and its great to have a PHP SDK made by you guys. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...ble to be encodable. This fixes the issue where the instances of ParseGeoPoint were not being encoded.