Skip to content

Add afterLogout trigger docs #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 9, 2020

Conversation

mtrezza
Copy link
Member

@mtrezza mtrezza commented Nov 15, 2019

Todo before merging:

  • Adapt line *Available only on parse-server cloud code starting 3.10.0* if necessary.

* commit 'e129790ed587819ecfcaed59fc7ff90ec6ffcfa1': (84 commits)
  Add `cascadeSave` option in ParseObject to JS docs (parse-community#664)
  Update apple sign in documentation (parse-community#662)
  Bump mixin-deep from 1.3.1 to 1.3.2 (parse-community#670)
  Update GraphQL docs with latest changes (parse-community#669)
  remove a bunch of parse cloud references (parse-community#654)
  docs: fixed examples for pipeline in aggregation (parse-community#661)
  Add beta notice to the GraphQL Guide (parse-community#659)
  iOS Documentation Revamp (parse-community#650)
  Fix doc for creating a subscription in javascript (parse-community#658)
  GraphQL Customisation (parse-community#652)
  added PhantAuth authData docs (parse-community#655)
  Fix typo in keys.md (parse-community#656)
  Fix typo in cloud-code.md (parse-community#657)
  add reference to afterFind, add more detail on predefined classes (parse-community#653)
  Add `keys` and `excludeKeys` options to REST docs (parse-community#649)
  document push type and priority keys for notifications (parse-community#639)
  Documentation for Sign In With Apple (parse-community#648)
  Documentation for isDataAvailable (parse-community#647)
  Remove line for 3.x (parse-community#646)
  Add documentation for query.withCount (parse-community#645)
  ...
@mtrezza
Copy link
Member Author

mtrezza commented Nov 15, 2019

Docs for parse-community/parse-server#6217

@mtrezza mtrezza changed the title Add afterLogout trigger Add afterLogout trigger docs Nov 15, 2019
@dplewis
Copy link
Member

dplewis commented Nov 15, 2019

Next release will be 4.0.0. It’s going to be massive, trust me

Copy link
Contributor

@TomWFox TomWFox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. We'll wait to merge until the server pr is merged and a release made.

Thanks for taking the time to document!

@mtrezza
Copy link
Member Author

mtrezza commented Nov 15, 2019

@TomWFox Thanks, just as reminder for us:

  • Adapt line Available only on parse-server cloud code starting 3.10.0 if necessary.

@TomWFox
Copy link
Contributor

TomWFox commented Jan 9, 2020

@mtrezza there is a merge conflict - I don't have time to resolve it now so if you can that would be great or I'll get to it in a day or so

@mtrezza
Copy link
Member Author

mtrezza commented Jan 9, 2020

@TomWFox let me take a look at it...

@mtrezza
Copy link
Member Author

mtrezza commented Jan 9, 2020

@TomWFox the merge conflict is the auto-generated bundle.js. I suggest to keep either of the versions and run webpack again to generate the new bundle.js, then merge. I don't have the access rights for that, do you?

@TomWFox
Copy link
Contributor

TomWFox commented Jan 9, 2020

Not sure, we did have this problem before, I seem to remember we just kept the version from the upstream master but I'm not certain.

@mtrezza
Copy link
Member Author

mtrezza commented Jan 9, 2020

@TomWFox What I could do is to rebase and submit a new PR, to be on the safe side. I think I won't be able to push to this branch after rebase. What do you think?

@dplewis
Copy link
Member

dplewis commented Jan 9, 2020

If I remember correctly we want to keep the upstream master bundle.js files since it gets generated.

@acinader explained the process here #606 (comment)

@mtrezza
Copy link
Member Author

mtrezza commented Jan 9, 2020

Thanks @dplewis, resolved by keeping upstream changes, ready to merge.

And you were right, 3.10 was massive! 👏

@dplewis
Copy link
Member

dplewis commented Jan 9, 2020

Should we add it to the gitignore since it will be generated anyway? Sorry not too familiar with the bundle process.

@TomWFox TomWFox merged commit 8cf7db7 into parse-community:gh-pages Jan 9, 2020
@mtrezza
Copy link
Member Author

mtrezza commented Jan 9, 2020

@dplewis gitignore makes sense to me, file is generated on every run.

@mtrezza mtrezza deleted the add-afterLogout-trigger branch January 9, 2020 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants