Update Libraries #81
Merged
Update Libraries #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wangmengyan95
commented
Oct 8, 2015
wangmengyan95
commented
- Update FB Utils to open source 1.10.3
- Update Twitter Utils to open source 1.10.3
- Update Parse to 1.10.3
- Update FB to 4.6.0
- Update Android Support Library to 23.0.1
- Delete FB Utils and Twitter Utils jar
- Update README.MD
wangmengyan95
force-pushed
the
wangmengyan.update_libraries
branch
from
a88850b to
c843bcb
Compare
wangmengyan95
force-pushed
the
wangmengyan.update_libraries
branch
from
c843bcb to
32b725d
Compare
| @@ -18,13 +18,13 @@ ext { | |||
| compileSdkVersion = 21 | |||
| buildToolsVersion = "21.1.1" | |||
|
|
|||
| minSdkVersion = 9 | |||
| minSdkVersion = 15 | |||
There was a problem hiding this comment.
what's the reason for this change?
There was a problem hiding this comment.
FB SDK requires this.
Actually it is a requirement for 4.6.0, if we use 4.4.0 then it is fine to keep it 9.
What do you think?
There was a problem hiding this comment.
Is this variable only used for the samples? It looks like ParseUI-Login and ParseUI-Widget still have minSdkVersion = 9. If this is the case, I think it's fine.
|
LGTM, we'll be targeting FB SDK 4.4.0 for minSdkVersion 9 compatibility, but 4.6.0 for our samples. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.