Convert all private ivars of PFUser to properties. #726
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| This earmarks the user as being an "identity" user. | ||
| This will make saves write through to the currentUser singleton and disk object | ||
| */ | ||
| @property (nonatomic, assign, getter=isCurrent, setter=setIsCurrent:) BOOL current; |
There was a problem hiding this comment.
Because PFUser could be subclassed, we should try to pick property names that are less likely to conflict (remember state, anyone?). I fear that lazy and current may already be in use by some applications, and I'd hate to cause incompatibilities for existing code.
There was a problem hiding this comment.
Sure. Let me use the same hack then as we used for '_state' :P
richardjrossiii
added
GH Review: needs-revision
and removed
GH Review: review-needed
labels
nlutsenko
force-pushed
the
nlutsenko.properties.user
branch
from
6abb14b to
8fe8b59
Compare
|
I can't wait for swift... |
nlutsenko
added a commit
that referenced
this pull request
Jan 5, 2016
Convert all private ivars of PFUser to properties.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added generic types to few of them.
Please note -
authDataneedsidfor object type, since we are usingNSNullfor it in few places.