-
-
Notifications
You must be signed in to change notification settings - Fork 877
ci: Fix test coverage with codecov #1726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening this pull request!
|
@mtrezza I think it works, I don't have full access to codecov. |
@mtrezza This is ready for review. Here is what the coverage looks like with everything included |
@mtrezza I made the changes. Can you review it again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks for this!
🎉 This change has been released in version 2.3.0 |
New Pull Request Checklist
Issue Description
Code coverage has been broken for a while with a number of factors contributing to it.
actions/codecov@3.1.0
introduced xcode support. I'm not sure ifCODECOV_TOKEN
is in the in the repository secretshttps://github.com/codecov/codecov-action/releases/tag/v3.1.0
Approach
TODO
CODECOV_TOKEN