Skip to content

update FBSDK from 6.x to 8.x #1580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 9, 2021
Merged

update FBSDK from 6.x to 8.x #1580

merged 6 commits into from
Jan 9, 2021

Conversation

eeallen1
Copy link
Contributor

@eeallen1 eeallen1 commented Dec 14, 2020

Facebook can't use the Advanced Matching feature for app events on iOS 14 devices with any FBSDk version older than 8.0. As far as I can tell, there are no breaking changes to ParseFacebookUtils

Close #1578

@cbaker6
Copy link
Contributor

cbaker6 commented Dec 16, 2020

Waiting to get the CI up and running in #1581 so we can make sure the update passes all of the tests

@drdaz drdaz mentioned this pull request Dec 17, 2020
4 tasks
@cbaker6
Copy link
Contributor

cbaker6 commented Jan 6, 2021

Can you rebase with the master branch?

@drdaz
Copy link
Member

drdaz commented Jan 7, 2021

🤔

@drdaz
Copy link
Member

drdaz commented Jan 8, 2021

It looks like the current version of FBSDK requires a minimum deployment target of 9.0 in the podspec, which is what's causing Cocoapods to fail.

EDIT: It looks like current Xcode feels the same way, since it's spitting up those warnings about supported OS versions.

@cbaker6
Copy link
Contributor

cbaker6 commented Jan 8, 2021

EDIT: It looks like current Xcode feels the same way, since it's spitting up those warnings about supported OS versions.

right, Xcode 12 wants this on all projects. I didn’t update the project in the actions PR just in case it broke something.

@drdaz
Copy link
Member

drdaz commented Jan 8, 2021

Imma try updating it here. EDIT: 🤞🏼

@drdaz
Copy link
Member

drdaz commented Jan 8, 2021

@cbaker This could probably use a review from somebody not me. But it's ready I think.

@cbaker
Copy link

cbaker commented Jan 8, 2021

@cbaker This could probably use a review from somebody not me. But it's ready I think.

yezzir

@drdaz
Copy link
Member

drdaz commented Jan 8, 2021

Sorry @cbaker, I meant @cbaker6 😂

@cbaker
Copy link

cbaker commented Jan 8, 2021

Sorry @cbaker, I meant @cbaker6 😂

I know happens a couple of times every other week 🤣 GL guys,

Copy link
Contributor

@cbaker6 cbaker6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@drdaz drdaz merged commit ea3f89c into parse-community:master Jan 9, 2021
@sarojkumarojha
Copy link

Hi @cbaker6 is this FBSDK from 6.x to 8.x is done ? when can we expect a release ? will it be part of 1.19.2 ?

@drdaz
Copy link
Member

drdaz commented Jan 18, 2021

It's merged into main. You should be fine using the current commit until there's a release.

@sarojkumarojha
Copy link

@drdaz
Is there any release from Parse near future with FBSDK > 9.x ?

@drdaz
Copy link
Member

drdaz commented Mar 5, 2021

I've been tied up with work for most of the beginning of this year. I should have some time to work here in the next couple weeks. I'll try and get one pushed then.

@ljs19923
Copy link

It's merged into main. You should be fine using the current commit until there's a release.

Hi @drdaz I installed the last release 1.19.1 with CoCoapods + Parse/FacebookUtils and it seems to install Facebook version 6.5.2, how can I upgrade to version 8 minimum?

Thanks

@sarojkumarojha have you been successful?

Capture d’écran 2021-03-10 à 10 51 17

@drdaz
Copy link
Member

drdaz commented Mar 10, 2021

@JulienLevallois I'm working on a release PR now. If you need it before the release is final, point your Cocoapods reference at the current commit on the main branch.

@ljs19923
Copy link

@drdaz Thanks a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FBSDKCoreKit dependency issue
6 participants