-
-
Notifications
You must be signed in to change notification settings - Fork 877
update FBSDK from 6.x to 8.x #1580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Waiting to get the CI up and running in #1581 so we can make sure the update passes all of the tests |
Can you rebase with the master branch? |
🤔 |
It looks like the current version of FBSDK requires a minimum deployment target of 9.0 in the podspec, which is what's causing Cocoapods to fail. EDIT: It looks like current Xcode feels the same way, since it's spitting up those warnings about supported OS versions. |
right, Xcode 12 wants this on all projects. I didn’t update the project in the actions PR just in case it broke something. |
Imma try updating it here. EDIT: 🤞🏼 |
@cbaker This could probably use a review from somebody not me. But it's ready I think. |
yezzir |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hi @cbaker6 is this FBSDK from 6.x to 8.x is done ? when can we expect a release ? will it be part of 1.19.2 ? |
It's merged into main. You should be fine using the current commit until there's a release. |
@drdaz |
I've been tied up with work for most of the beginning of this year. I should have some time to work here in the next couple weeks. I'll try and get one pushed then. |
Hi @drdaz I installed the last release 1.19.1 with CoCoapods + Parse/FacebookUtils and it seems to install Facebook version 6.5.2, how can I upgrade to version 8 minimum? Thanks @sarojkumarojha have you been successful? |
@JulienLevallois I'm working on a release PR now. If you need it before the release is final, point your Cocoapods reference at the current commit on the main branch. |
@drdaz Thanks a lot |
Facebook can't use the Advanced Matching feature for app events on iOS 14 devices with any FBSDk version older than 8.0. As far as I can tell, there are no breaking changes to ParseFacebookUtils
Close #1578