Skip to content

Updating submodule versions to fix build. #1454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 25, 2019
Merged

Updating submodule versions to fix build. #1454

merged 7 commits into from
Sep 25, 2019

Conversation

noobs2ninjas
Copy link
Member

@noobs2ninjas noobs2ninjas commented Sep 25, 2019

Completes issue #1446 by updating submodules and fixing Travis and CircleCI build.

@noobs2ninjas
Copy link
Member Author

noobs2ninjas commented Sep 25, 2019

This is awaiting a xctoolchain update so I can do a submodule update and push the changes here. After that we should be good to go. Also, I'll be doing a few updates to remove some of the unnecessary changes made by running git submodule fetch scripts that updated carthage checkouts to master instead of most recent release.

@drdaz
Copy link
Member

drdaz commented Sep 25, 2019

@noobs2ninjas
Copy link
Member Author

Haha did you check the log? It's like 11,700 lines long on the deployment job.

@drdaz
Copy link
Member

drdaz commented Sep 25, 2019

I hadn't. I'm a simple man. I see green and I'm happy.

But now I have and yeah that's a big log ^^

@drdaz
Copy link
Member

drdaz commented Sep 25, 2019

Dude. The whole suite passed. 👏🏼

@noobs2ninjas
Copy link
Member Author

Haha been a little while since that happened?

@noobs2ninjas noobs2ninjas merged commit 4c7cd8d into parse-community:master Sep 25, 2019
@drdaz
Copy link
Member

drdaz commented Sep 25, 2019

I mean, it'll be interesting to see how consistent it is. The (x)OS tests have been inconsistent for a long time. I have some hope these updates might help with that.

@noobs2ninjas
Copy link
Member Author

Im curious why the iOS tests all the sudden pass. Doesnt make sense to me.

@drdaz
Copy link
Member

drdaz commented Sep 25, 2019

It's not all of a sudden. They pass most of the time.

@drdaz
Copy link
Member

drdaz commented Sep 25, 2019

Or... at least some of the time. That's what I mean; they're inconsistent.

@noobs2ninjas
Copy link
Member Author

Spoke too fast. Master CircleCI build still fails.

@drdaz
Copy link
Member

drdaz commented Sep 25, 2019

Yeah; still inconsistent. 😞

The same tests are inconsistent locally too which is kind of comforting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants