-
-
Notifications
You must be signed in to change notification settings - Fork 877
Updating submodule versions to fix build. #1454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is awaiting a xctoolchain update so I can do a submodule update and push the changes here. After that we should be good to go. Also, I'll be doing a few updates to remove some of the unnecessary changes made by running git submodule fetch scripts that updated carthage checkouts to master instead of most recent release. |
Haha did you check the log? It's like 11,700 lines long on the deployment job. |
I hadn't. I'm a simple man. I see green and I'm happy. But now I have and yeah that's a big log ^^ |
Dude. The whole suite passed. 👏🏼 |
Haha been a little while since that happened? |
I mean, it'll be interesting to see how consistent it is. The (x)OS tests have been inconsistent for a long time. I have some hope these updates might help with that. |
Im curious why the iOS tests all the sudden pass. Doesnt make sense to me. |
It's not all of a sudden. They pass most of the time. |
Or... at least some of the time. That's what I mean; they're inconsistent. |
Spoke too fast. Master CircleCI build still fails. |
Yeah; still inconsistent. 😞 The same tests are inconsistent locally too which is kind of comforting. |
Completes issue #1446 by updating submodules and fixing Travis and CircleCI build.