Skip to content

fix: Conflict with new version of connectivity_plus dependency #987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Feb 13, 2024
Merged

fix: Conflict with new version of connectivity_plus dependency #987

merged 16 commits into from
Feb 13, 2024

Conversation

mbfakourii
Copy link
Member

@mbfakourii mbfakourii commented Jan 22, 2024 •
edited
Loading

Pull Request

Issue

Closes: #986

Approach

Upgrade flutter dependencies

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)

@parse-github-assistant Parse GitHub Assistant
Copy link

Thanks for opening this pull request!

@mbfakourii mbfakourii changed the title chore: Upgrade flutter dependencies refactor: Upgrade flutter dependencies Jan 22, 2024
@mbfakourii mbfakourii requested review from a team and removed request for a team January 22, 2024 17:36
@codecov Codecov
Copy link

codecov bot commented Jan 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c5f08f6) 44.12% compared to head (be994db) 44.16%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #987      +/-   ##
==========================================
+ Coverage   44.12%   44.16%   +0.03%     
==========================================
  Files          60       60              
  Lines        3404     3401       -3     
==========================================
  Hits         1502     1502              
+ Misses       1902     1899       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mbfakourii mbfakourii requested a review from a team January 22, 2024 18:21
@mbfakourii mbfakourii requested review from a team and removed request for a team January 30, 2024 18:30
mtrezza
mtrezza reviewed Jan 31, 2024
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, is this really just a refactor (no release will be published with this PR)?

@mbfakourii
Copy link
Member Author

Looks good, is this really just a refactor (no release will be published with this PR)?

To solve issues number #986, I think it is better to release a new version.

@mtrezza
Copy link
Member

mtrezza commented Jan 31, 2024

To release a new version, could you please as usual increase the version in the package and change the PR title to fix if it's a bug fix?

@mbfakourii mbfakourii changed the title refactor: Upgrade flutter dependencies fix: Upgrade flutter dependencies Feb 1, 2024
@mbfakourii
Copy link
Member Author

To release a new version, could you please as usual increase the version in the package and change the PR title to fix if it's a bug fix?

Done

@mtrezza
Copy link
Member

mtrezza commented Feb 1, 2024

Could you please review the PR title - if it's a fix it should describe the bug; if it's not a bug fix it may be a feat, for example to introduce compatibility.

@mbfakourii mbfakourii changed the title fix: Upgrade flutter dependencies fix: Upgrade connectivity_plus package to resolve the conflict with the new connectivity_plus version Feb 2, 2024
@mbfakourii
Copy link
Member Author

Could you please review the PR title - if it's a fix it should describe the bug; if it's not a bug fix it may be a feat, for example to introduce compatibility.

Changed.

@mtrezza mtrezza changed the title fix: Upgrade connectivity_plus package to resolve the conflict with the new connectivity_plus version fix: Conflict with the new version of connectivity_plus dependency Feb 3, 2024
@mtrezza mtrezza changed the title fix: Conflict with the new version of connectivity_plus dependency fix: Conflict with new version of connectivity_plus dependency Feb 3, 2024
mtrezza
mtrezza reviewed Feb 3, 2024
View reviewed changes
mtrezza
mtrezza reviewed Feb 3, 2024
View reviewed changes
mtrezza
mtrezza approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtrezza mtrezza merged commit 540b127 into parse-community:master Feb 13, 2024
@mbfakourii mbfakourii deleted the upgrade_flutter_dependencies branch March 9, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

connectivity_plus plugin latest versions are not supported
2 participants
@mbfakourii @mtrezza