Skip to content

fix: Malformed JSON in whereMatchesQuery #955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 18, 2023

Conversation

juriSacchetta
Copy link
Contributor

Pull Request

Issue

Re-open PR: #943
Closes: #939

Approach

Fix bug in JSON creation when whereMatchesQuery is used.

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)

@parse-github-assistant
Copy link

Thanks for opening this pull request!

@mtrezza mtrezza changed the title Fix malformed JSON in _buildQueryRelational fix: malformed JSON in _buildQueryRelational Jul 15, 2023
@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title fix: malformed JSON in _buildQueryRelational fix: Malformed JSON in _buildQueryRelational Jul 15, 2023
@mtrezza mtrezza changed the title fix: Malformed JSON in _buildQueryRelational fix: Malformed JSON in whereMatchesQuery Jul 15, 2023
@codecov
Copy link

codecov bot commented Jul 15, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (c9d64cb) 39.31% compared to head (6f31021) 39.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #955      +/-   ##
==========================================
+ Coverage   39.31%   39.33%   +0.01%     
==========================================
  Files          60       60              
  Lines        3355     3356       +1     
==========================================
+ Hits         1319     1320       +1     
  Misses       2036     2036              
Impacted Files Coverage Δ
packages/dart/lib/src/network/parse_query.dart 45.28% <100.00%> (+0.20%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@mbfakourii mbfakourii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for the test

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a changelog entry?

@juriSacchetta
Copy link
Contributor Author

Could you add a changelog entry?

I don't know how to do it, can you give me some indication?

@mbfakourii
Copy link
Member

mbfakourii commented Jul 17, 2023

Could you add a changelog entry?

I don't know how to do it, can you give me some indication?

An example is in this PR.

It means is adding changes and bump version (increasing the package version).

@juriSacchetta
Copy link
Contributor Author

Could you add a changelog entry?

I don't know how to do it, can you give me some indication?

An example is in this PR.

It means is adding changes and bump version (increasing the package version).

Thank you for your reply. Please let me know if it's alright now.

@mbfakourii
Copy link
Member

Could you add a changelog entry?

I don't know how to do it, can you give me some indication?

An example is in this PR.
It means is adding changes and bump version (increasing the package version).

Thank you for your reply. Please let me know if it's alright now.

Looks good

@mtrezza mtrezza merged commit aefc84e into parse-community:master Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URL Escaping Error in Parse SDK's whereRelatedTo Method
3 participants