-
-
Notifications
You must be signed in to change notification settings - Fork 208
fix: Malformed JSON in whereMatchesQuery
#955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for opening this pull request! |
I will reformat the title to use the proper commit message syntax. |
whereMatchesQuery
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #955 +/- ##
==========================================
+ Coverage 39.31% 39.33% +0.01%
==========================================
Files 60 60
Lines 3355 3356 +1
==========================================
+ Hits 1319 1320 +1
Misses 2036 2036
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks for the test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a changelog entry?
I don't know how to do it, can you give me some indication? |
An example is in this PR. It means is adding changes and bump version (increasing the package version). |
Thank you for your reply. Please let me know if it's alright now. |
Looks good |
Pull Request
Issue
Re-open PR: #943
Closes: #939
Approach
Fix bug in JSON creation when
whereMatchesQuery
is used.Tasks