Add update server url #985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Jawnnypoo any time estimate when this will be reviewed? |
|
Did you verify that this works with your own project? |
|
@Jawnnypoo yes, we are even using this in production already. |
Jawnnypoo
approved these changes
Nov 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a) Added the possibility to set and get the current server URL without having to destroy and re-initialize the client. Example use case: domain failover handling.
b) Added docs note to
destroymethod that the client should not be destroyed while a rest call is in progress. This leads to an unhandled exception. Ideally the exception should be handled, so if anyone got the time they can look into that at some point.