BUG: fix common.is_hashable for NumPy scalars on Python 3 #9473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes GH9276 This now relies entirely on the result of calling ``hash`` on the argument. Note: I had to change the test for old style classes on Python 2 -- these are now considered hashable by `is_hashable`, because they don't fail `hash`. CC aevri
|
lgtm |
jreback
added a commit
that referenced
this pull request
Feb 16, 2015
BUG: fix common.is_hashable for NumPy scalars on Python 3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9276
This now relies entirely on the result of calling
hashon the argument.Note: I had to change the test for old style classes on Python 2 -- these are
now considered hashable by
is_hashable, because they don't failhash.CC @aevri