Updating generic.py error message #8618

springcoil · 2014-10-23T21:14:23Z

This is my first attempt at a PR. I just made a little change to allow an error message. Would appreciate some feedback.
closes #8015

jorisvandenbossche · 2014-10-23T21:20:08Z

pandas/core/generic.py

+            return groupby(self, by, axis=axis, level=level, as_index=as_index,
+                        sort=sort, group_keys=group_keys, squeeze=squeeze)
+        except AttributeError:
+            raise TypeError('You have to at least specify one of by or level')


can you quote by and level ? (so "You ... 'by' or 'level'"), then it is more clear it are the keywords

jorisvandenbossche · 2014-10-23T21:23:27Z

Thanks for the PR!

Strange, for some reason Travis is not triggered to run the test suite.

springcoil · 2014-10-24T07:16:20Z

Hi Joris,
I just realized I was a bit tired yesterday when I wrote all of this without triggering the travis test suite.
I will add that and update above.

springcoil · 2014-10-27T10:37:01Z

Updated based on your previous comments Joris. Let me know what you think.

jreback · 2014-10-27T10:38:57Z

going to need a specific test to validate this new behavior (eg need to hit and validate each of the branches)

model after assertRaisesRegex usage

springcoil · 2014-10-27T12:23:46Z

Any suggestion what I test for - just by each argument?

jreback · 2014-10-27T12:37:12Z

someting like (error message should match, this was off the cuff)

def f():
     df.groupby()
self.assertRaisesRegexp(TypeError, f, "You have to supply one of 'by' or 'level'")

so should have 4 tests to cover
put in tests/test_groupby.py (their might be some existing tests, put with those)

springcoil · 2014-10-27T18:45:59Z

Let me know if this works or not. I had some travis CI problems. Submitting a new build

springcoil · 2014-10-27T21:53:48Z

The updated code is added included the tests. It passes the Travis CI build

jreback · 2014-10-27T22:07:17Z

pandas/tests/test_groupby.py

@@ -1981,6 +1993,32 @@ def test_groupby_level_apply(self):
        result = frame['A'].groupby(level=0).count()
        self.assertEqual(result.index.name, 'first')

+        def g():


just put all of these under one new function (the 4 tests), maybe test_groupby_args

add the issue number as a comment

jreback · 2014-10-27T22:19:59Z

see git help here:https://github.com/pydata/pandas/wiki/Using-Git

just rebase the offending commit away and force push

springcoil · 2014-10-29T23:10:37Z

any update?

jreback · 2014-10-29T23:17:10Z

hmm, it seems you have lost the actual change you made. The tests are there though.

springcoil · 2014-10-30T08:29:18Z

Sorting it out now :)

On Thu, Oct 30, 2014 at 12:17 AM, jreback notifications@github.com wrote:

hmm, it seems you have lost the actual change you made. The tests are
there though.

—
Reply to this email directly or view it on GitHub
#8618 (comment).

Peadar Coyle
Skype: springcoilarch
www.twitter.com/springcoil
peadarcoyle.wordpress.com

jorisvandenbossche · 2014-10-30T09:50:21Z

pandas/tests/test_groupby.py

+        frame = self.mframe
+        def g():
+            frame.groupby(level=None).count()
+            self.assertRaisesRegexp(TypeError, g, "You have to supply one of 'by' or 'level'")


The assert should not be in the function definition, as in this way it is not called:

def g(): frame.groupby(..) self.assert ...

springcoil · 2014-10-30T11:54:26Z

@hayd Hey Andy, I was having a look at this - andd got some feedback (bad tests the first time I submitted). I'm trying to figure out a way to test for df.groupby() as we all agree that should return an error. But I keep running into the errors above in my tests. Any suggestions?

Fix unrecognized 'Z' UTC designator

DOC: Issue #8805

For consistency with [PEP8][1]: Imports are always put at the top of the file, just after any module comments and docstrings, and before module globals and constants. [1]: https://www.python.org/dev/peps/pep-0008#id17

CLN: move import to top of file

Option context no longer overrides options when used outside a `with` statement. Added test TestConfig.test_option_config_scope Closes #8514

DOC: specify return type in to_datetime

BUG: Option context applies on __enter__

$ nosetests pandas/core/common.py --with-doc -v

BUG: DatetimeIndex with time object as key

BUG: fix doctests in pandas.core.common

Categorical: let unique only return used categories

jreback · 2014-11-30T17:32:27Z

@springcoil ?

springcoil · 2014-11-30T17:48:48Z

Sorry @jreback just rebasing and submitting now.

springcoil · 2014-11-30T18:39:34Z

Still getting some test failures - but none seem related my own code... I'm a bit confused. Does anyone have any advice?

jorisvandenbossche · 2014-11-30T23:16:37Z

You have included a lot of other commits, maybe something there is causing the errors. Can you do on your branch:

git fetch upstream
git rebase upstream/master
git push -f origin PR8015

springcoil · 2014-12-01T08:18:34Z

Deleting this branch - starting again - with a new one, this might make it easier.
See #8950

jorisvandenbossche reviewed Oct 23, 2014
View reviewed changes

jreback added the Error Reporting Incorrect or improved errors from pandas label Oct 24, 2014

jreback added this to the 0.15.1 milestone Oct 24, 2014

jreback reviewed Oct 27, 2014
View reviewed changes

Updating tests file Cleaning up

589098c

Updating generic file to include change

2e3c35b

jorisvandenbossche reviewed Oct 30, 2014
View reviewed changes

jreback modified the milestones: 0.15.2, 0.15.1 Oct 30, 2014

Pushing code for review

f41ef3d

jreback and others added 14 commits November 27, 2014 12:48

Merge pull request #8832 from broessli/z-utc

9fd99d7

Fix unrecognized 'Z' UTC designator

Doc change for Issue #8805

c8e36d4

Merge pull request #8912 from vvbchaves/master

a3e478d

DOC: Issue #8805

DOC: specify return type in to_datetime

3b2089b

CLN: move import to top of file

cfcda5f

For consistency with [PEP8][1]: Imports are always put at the top of the file, just after any module comments and docstrings, and before module globals and constants. [1]: https://www.python.org/dev/peps/pep-0008#id17

Merge pull request #8922 from aevri/refactor/move_import

99a7318

CLN: move import to top of file

BUG: Option context applies on __enter__

f21539b

Option context no longer overrides options when used outside a `with` statement. Added test TestConfig.test_option_config_scope Closes #8514

Merge pull request #8921 from jorisvandenbossche/docstring-to_datetime

26129f5

DOC: specify return type in to_datetime

Merge pull request #8925 from hkleynhans/fix/8514_option_context_with

e9ee47c

BUG: Option context applies on __enter__

BUG: fix doctests in pandas.core.common

fef4b09

$ nosetests pandas/core/common.py --with-doc -v

Merge pull request #8907 from behzadnouri/time-slice

e2f8f0a

BUG: DatetimeIndex with time object as key

Merge pull request #8931 from rupertthompson/fix/core_common_doctests

2e59e42

BUG: fix doctests in pandas.core.common

TST: 32-bit construction fix re GH8907

e759d99

Merge pull request #8937 from JanSchulz/cat_unique2

8290a4d

Categorical: let unique only return used categories

springcoil added 7 commits November 30, 2014 18:42

Updating tests file Cleaning up

bcaf7fd

Updating generic file to include change

d55f582

Pushing code for review

b1168b5

updating after tests fail

ca70dbe

Updating due to errors

11c53a7

Updating including test fails

baa8cd6

Updating test files

ab1c90f

springcoil added 2 commits November 30, 2014 18:55

Adding generic.py etc

e40215a

Refactoring slightly

49bd373

springcoil closed this Dec 1, 2014

springcoil deleted the PR8015 branch December 1, 2014 08:13

Uh oh!

Updating generic.py error message #8618

Updating generic.py error message #8618

Uh oh!

Conversation

springcoil commented Oct 23, 2014

Uh oh!

jorisvandenbossche Oct 23, 2014

Choose a reason for hiding this comment

Uh oh!

jorisvandenbossche commented Oct 23, 2014

Uh oh!

springcoil commented Oct 24, 2014

Uh oh!

springcoil commented Oct 27, 2014

Uh oh!

jreback commented Oct 27, 2014

Uh oh!

springcoil commented Oct 27, 2014

Uh oh!

jreback commented Oct 27, 2014

Uh oh!

springcoil commented Oct 27, 2014

Uh oh!

springcoil commented Oct 27, 2014

Uh oh!

jreback Oct 27, 2014

Choose a reason for hiding this comment

Uh oh!

jreback Oct 27, 2014

Choose a reason for hiding this comment

Uh oh!

jreback commented Oct 27, 2014

Uh oh!

springcoil commented Oct 29, 2014

Uh oh!

jreback commented Oct 29, 2014

Uh oh!

springcoil commented Oct 30, 2014

Uh oh!

jorisvandenbossche Oct 30, 2014

Choose a reason for hiding this comment

Uh oh!

springcoil commented Oct 30, 2014

Uh oh!

jreback commented Nov 30, 2014

Uh oh!

springcoil commented Nov 30, 2014

Uh oh!

springcoil commented Nov 30, 2014

Uh oh!

jorisvandenbossche commented Nov 30, 2014

Uh oh!

springcoil commented Dec 1, 2014

Uh oh!

Uh oh!