BUG: do not assume 0 is in index of potential Series #7902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fyi, you don't normally need to close and reopen the PR, just force push, see here: https://github.com/pydata/pandas/wiki/Using-Git |
jreback
added a commit
that referenced
this pull request
Aug 2, 2014
BUG: do not assume 0 is in index of potential Series
|
Thanks; OK for the force push in the future (just feared it was unpolite), but the page you linked doesn't mention it! |
|
no unless you are working with someone else then almost always better to force push (and if you are then someone needs to periodically rebase), just much cleaner that way IMHO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7857... this time it checks also for a Series (and it passes all tests).