FIX: Enable fixed width strings to be read from Stata 13 (117) files #7450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug which prevented files containing fixed width string data from being read. Stata 13 files also allow variable length strings, which are not supported in the current version, and an explicit exception regarding this type is now given. Added tests which cover these cases, and Stata 13 format files. fixes pandas-dev#7360
The encoding was not used when writing strings. Fixes pandas-dev#7286
|
I think this fix is ready - it is a bit ugly due to some existing PY3 compatibility code that probably has string encoding in the wrong place, but it is working. |
jreback
added a commit
that referenced
this pull request
Jun 16, 2014
FIX: Enable fixed width strings to be read from Stata 13 (117) files
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug which prevented files containing fixed width string data from being read. Stata 13 files also allow variable length strings, which are not supported in the current version, and an explicit exception regarding this type is now given. Added tests which cover these cases, and Stata 13 format files.
fixes #7360