TST: Changed the error raised by no tables in data.Options #7392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it ever the case that there are more than 0 tables found but a table location is invalid? |
|
If 2 tables are found, and you wanted location 3 |
|
Not really a |
|
Good point. I was trying to think of how to make fail in the case that Yahoo changes their tables around. |
Tests were failing if the scraper got the webpage but there weren't any tables in it. Added condition to raise RemoteDataError if no tables were found. Still IndexError if it can't find the correct table.
|
@jreback comments? i think this is ok |
|
ok |
cpcloud
added a commit
that referenced
this pull request
Jun 8, 2014
TST: Changed the error raised by no tables in data.Options
|
@dstephens99 thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests were failing if the scraper got the webpage but there weren't any tables in it. Added condition to raise RemoteDataError if no tables were found. Still IndexError if it can't find the correct table.
fixes #7335