TST: fix intermittent dict_complex test failures #7298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| all(map(lambda x, y: type(x) == type(y), x.values(), x_rec.values()))) | ||
| for key in x: | ||
| self.assertEqual(x[key], x_rec[key]) | ||
| self.assertEqual(type(x[key]), type(x_rec[key])) |
There was a problem hiding this comment.
This looks good and much cleaner. I can see why this is not very reproducable!
Is it worth checking isEqual(len(x), len(x_rec)) or maybe which is implicitly done with the map ?isEqual(x.keys(), x_rec.keys()) (sigh, this isn't a set in python 2)
`test_dict_complex` and `test_dict_numpy_complex` would give occasional test failures on Python 3.4. The test was written to depend on the order of values from `dict.values()`; remove that dependency. Closes pandas-devgh-7293.
|
Good point - how about this version? |
|
yeh these tests were ripped from the numpy-msgpack impl thanks ! |
hayd
added a commit
that referenced
this pull request
May 31, 2014
TST: fix intermittent dict_complex test failures
|
nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_dict_complexandtest_dict_numpy_complexwould give occasional testfailures on Python 3.4. The test was written to depend on the order of values
from
dict.values(); remove that dependency.Closes gh-7293.