BUG: Fix behavior of to_offset with leading zeroes #6391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, `pandas.tseries.frequencies.to_offset` erroneously returns a zero time offset when the first part of its argument has a numerical value of zero, even if later parts have nonzero values. For instance,
In [123]: pandas.tseries.frequencies.to_offset('00H 00T 01S')
Out[123]: <0 * Days>
In this patch the sign check is applied before conversion to `int` in order to support offsets like `'-00H 00T 01S'`.
Test for the issues fixed by cbc8c73.
|
this is fine; can you add a release note (referencing this PR) in Bug Fixes section. thanks |
|
edit |
|
Found it. Thanks! |
|
I assume I don't have to merge your fix for the test failure into this branch; let me know if I do. |
| @@ -96,6 +96,7 @@ Improvements to existing features | |||
| Bug Fixes | |||
| ~~~~~~~~~ | |||
|
|
|||
| - Bug in ``pd.tseries.frequencies.to_offset`` when argument has leading zeroes (:issue:`6391`) | |||
There was a problem hiding this comment.
FYI, we usually put the bug fixes at the end, but ok
|
@ischwabacher nope....you could pull master and then rebase (which would pick it up)....but not really necessary as their is no conflict here thanks for the fix! |
jreback
added a commit
that referenced
this pull request
Feb 18, 2014
BUG: Fix behavior of to_offset with leading zeroes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
pandas.tseries.frequencies.to_offseterroneously returns a zero time offset when the first part of its argument has a numerical value of zero, even if later parts have nonzero values. For instance,This change checks the sign of the numeric part of the argument before converting to
intin order to support offsets like'-00H 00T 01S'.