-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
ENH: Support plugin DataFrame accessor via entry points (#29076) #61499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PedroM4rques
wants to merge
4
commits into
pandas-dev:main
Choose a base branch
from
PedroM4rques:feature
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+67
−0
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
9962904
ENH: Support plugin DataFrame accessor via entry points (#29076)
PedroM4rques ded0b0d
add whatsnew entry && type annotations
PedroM4rques f2a036e
fix typo in importlib.metadata
PedroM4rques fcfa155
trying to fix the pipeline errors
PedroM4rques File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
import pandas as pd | ||
from pandas.core.accessor import DataFrameAccessorLoader | ||
|
||
|
||
def test_load_dataframe_accessors(monkeypatch): | ||
# GH29076 | ||
# Mocked EntryPoint to simulate a plugin | ||
class MockEntryPoint: | ||
name = "test_accessor" | ||
|
||
def load(self): | ||
class TestAccessor: | ||
def __init__(self, df): | ||
self._df = df | ||
|
||
def test_method(self): | ||
return "success" | ||
|
||
return TestAccessor | ||
|
||
# Mock entry_points | ||
def mock_entry_points(*, group): | ||
if group == DataFrameAccessorLoader.ENTRY_POINT_GROUP: | ||
return [MockEntryPoint()] | ||
return [] | ||
|
||
# Patch entry_points in the correct module | ||
monkeypatch.setattr("pandas.core.accessor.entry_points", mock_entry_points) | ||
|
||
DataFrameAccessorLoader.load() | ||
|
||
# Create DataFrame and verify that the accessor was registered | ||
df = pd.DataFrame({"a": [1, 2, 3]}) | ||
assert hasattr(df, "test_accessor") | ||
assert df.test_accessor.test_method() == "success" |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why a class with a single method?
And why only doing this for
DataFrame
, not forSeries
?