-
-
Notifications
You must be signed in to change notification settings - Fork 18.5k
DataFrame.dtypes.to_json OverflowError: Maximum recursion level reached #61171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Am I correct in saying that the infinite recursion occurs because we never made it into one of the if/else if chain? Perhaps we should raise somehow if this occurs?
) | ||
def test_dtypes_to_json_consistency(df: DataFrame): | ||
# GH 61170 | ||
expected = df.dtypes.apply(str).to_json() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of creating multiple objects like this can you write out what the expected JSON representation is and compare that to the result of a to_json()
call?
@pytest.mark.parametrize( | ||
"df", | ||
[ | ||
DataFrame({"A": [1, 2, 3], "B": [4, 5, 6]}), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need parametrization for this? What makes the test cases different?
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen. |
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.